[PATCH 1/1] iio: industrialio-trigger: Use 'gnu_printf' format notation

[PATCH 1/1] iio: industrialio-trigger: Use 'gnu_printf' format notation

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/iio/industrialio-trigger.c: In function ‘iio_alloc_pollfunc’:
 drivers/iio/industrialio-trigger.c:338:2: warning: function ‘iio_alloc_pollfunc’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/iio/industrialio-trigger.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
index 583bb51f65a75..1d65c83439d84 100644
--- a/drivers/iio/industrialio-trigger.c
+++ b/drivers/iio/industrialio-trigger.c
@@ -320,6 +320,7 @@ irqreturn_t iio_pollfunc_store_time(int irq, void *p)
 }
 EXPORT_SYMBOL(iio_pollfunc_store_time);
 
+__printf(5, 6)
 struct iio_poll_func
 *iio_alloc_pollfunc(irqreturn_t (*h)(int irq, void *p),
 		    irqreturn_t (*thread)(int irq, void *p),
-- 
2.25.1

Re: [PATCH 1/1] iio: industrialio-trigger: Use 'gnu_printf' format notation

[Lars-Peter Clausen]

On 11/2/20 12:17 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
>   drivers/iio/industrialio-trigger.c: In function ‘iio_alloc_pollfunc’:
>   drivers/iio/industrialio-trigger.c:338:2: warning: function ‘iio_alloc_pollfunc’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Jonathan already sent a similar patch. See 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd7798cbd28044a3026619e36993160ba8fa118d 
<https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd7798cbd28044a3026619e36993160ba8fa118d>

>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>   drivers/iio/industrialio-trigger.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index 583bb51f65a75..1d65c83439d84 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -320,6 +320,7 @@ irqreturn_t iio_pollfunc_store_time(int irq, void *p)
>   }
>   EXPORT_SYMBOL(iio_pollfunc_store_time);
>   
> +__printf(5, 6)
>   struct iio_poll_func
>   *iio_alloc_pollfunc(irqreturn_t (*h)(int irq, void *p),
>   		    irqreturn_t (*thread)(int irq, void *p),

Re: [PATCH 1/1] iio: industrialio-trigger: Use 'gnu_printf' format notation

[Lee Jones]

On Mon, 02 Nov 2020, Lars-Peter Clausen wrote:

> On 11/2/20 12:17 PM, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> > 
> >   drivers/iio/industrialio-trigger.c: In function ‘iio_alloc_pollfunc’:
> >   drivers/iio/industrialio-trigger.c:338:2: warning: function ‘iio_alloc_pollfunc’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> 
> Jonathan already sent a similar patch. See
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd7798cbd28044a3026619e36993160ba8fa118d
> <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd7798cbd28044a3026619e36993160ba8fa118d>

So adding this to the prototype also squashes the warning?

> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >   drivers/iio/industrialio-trigger.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> > index 583bb51f65a75..1d65c83439d84 100644
> > --- a/drivers/iio/industrialio-trigger.c
> > +++ b/drivers/iio/industrialio-trigger.c
> > @@ -320,6 +320,7 @@ irqreturn_t iio_pollfunc_store_time(int irq, void *p)
> >   }
> >   EXPORT_SYMBOL(iio_pollfunc_store_time);
> > +__printf(5, 6)
> >   struct iio_poll_func
> >   *iio_alloc_pollfunc(irqreturn_t (*h)(int irq, void *p),
> >   		    irqreturn_t (*thread)(int irq, void *p),
> 
> 

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/1] iio: industrialio-trigger: Use 'gnu_printf' format notation

[Jonathan Cameron]

On Mon, 2 Nov 2020 11:37:23 +0000
Lee Jones <lee.jones@linaro.org> wrote:

> On Mon, 02 Nov 2020, Lars-Peter Clausen wrote:
> 
> > On 11/2/20 12:17 PM, Lee Jones wrote:  
> > > Fixes the following W=1 kernel build warning(s):
> > > 
> > >   drivers/iio/industrialio-trigger.c: In function ‘iio_alloc_pollfunc’:
> > >   drivers/iio/industrialio-trigger.c:338:2: warning: function ‘iio_alloc_pollfunc’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]  
> > 
> > Jonathan already sent a similar patch. See
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd7798cbd28044a3026619e36993160ba8fa118d
> > <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd7798cbd28044a3026619e36993160ba8fa118d>  
> 
> So adding this to the prototype also squashes the warning?
I'm not seeing the warning any more so I guess so?

J

> 
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >   drivers/iio/industrialio-trigger.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> > > index 583bb51f65a75..1d65c83439d84 100644
> > > --- a/drivers/iio/industrialio-trigger.c
> > > +++ b/drivers/iio/industrialio-trigger.c
> > > @@ -320,6 +320,7 @@ irqreturn_t iio_pollfunc_store_time(int irq, void *p)
> > >   }
> > >   EXPORT_SYMBOL(iio_pollfunc_store_time);
> > > +__printf(5, 6)
> > >   struct iio_poll_func
> > >   *iio_alloc_pollfunc(irqreturn_t (*h)(int irq, void *p),
> > >   		    irqreturn_t (*thread)(int irq, void *p),  
> > 
> >   
>