* [PATCH] iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config
@ 2021-11-11 8:39 Lukas Bulwahn
2021-11-11 10:31 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Lukas Bulwahn @ 2021-11-11 8:39 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, Cai Huoqing, Fabio Estevam,
linux-iio
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP
ADC") adds the config IMX8QXP_ADC for this new driver, which depends on
the non-existing config ARCH_MXC_ARM64.
Hence, ./scripts/checkkconfigsymbols.py warns:
ARCH_MXC_ARM64
Referencing files: drivers/iio/adc/Kconfig
Probably, the existing config ARCH_MXC is intended to be referred here.
So, repair the dependency to refer to that config.
Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/iio/adc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 8bf5b62a73f4..3363af15a43f 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -532,7 +532,7 @@ config IMX7D_ADC
config IMX8QXP_ADC
tristate "NXP IMX8QXP ADC driver"
- depends on ARCH_MXC_ARM64 || COMPILE_TEST
+ depends on ARCH_MXC || COMPILE_TEST
depends on HAS_IOMEM
help
Say yes here to build support for IMX8QXP ADC.
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config
2021-11-11 8:39 [PATCH] iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config Lukas Bulwahn
@ 2021-11-11 10:31 ` Fabio Estevam
2021-11-12 16:20 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2021-11-11 10:31 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Jonathan Cameron, Lars-Peter Clausen, Cai Huoqing, linux-iio,
kernel-janitors, linux-kernel
Hi Lukas,
On Thu, Nov 11, 2021 at 5:40 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP
> ADC") adds the config IMX8QXP_ADC for this new driver, which depends on
> the non-existing config ARCH_MXC_ARM64.
>
> Hence, ./scripts/checkkconfigsymbols.py warns:
>
> ARCH_MXC_ARM64
> Referencing files: drivers/iio/adc/Kconfig
>
> Probably, the existing config ARCH_MXC is intended to be referred here.
> So, repair the dependency to refer to that config.
>
> Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
This looks good.
The incorrect ARCH_MXC_ARM64 symbol probably came when porting the
driver from the NXP downstream kernel:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config
2021-11-11 10:31 ` Fabio Estevam
@ 2021-11-12 16:20 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2021-11-12 16:20 UTC (permalink / raw)
To: Fabio Estevam
Cc: Lukas Bulwahn, Lars-Peter Clausen, Cai Huoqing, linux-iio,
kernel-janitors, linux-kernel
On Thu, 11 Nov 2021 07:31:25 -0300
Fabio Estevam <festevam@gmail.com> wrote:
> Hi Lukas,
>
> On Thu, Nov 11, 2021 at 5:40 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP
> > ADC") adds the config IMX8QXP_ADC for this new driver, which depends on
> > the non-existing config ARCH_MXC_ARM64.
> >
> > Hence, ./scripts/checkkconfigsymbols.py warns:
> >
> > ARCH_MXC_ARM64
> > Referencing files: drivers/iio/adc/Kconfig
> >
> > Probably, the existing config ARCH_MXC is intended to be referred here.
> > So, repair the dependency to refer to that config.
> >
> > Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>
> This looks good.
>
> The incorrect ARCH_MXC_ARM64 symbol probably came when porting the
> driver from the NXP downstream kernel:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-12 16:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-11 8:39 [PATCH] iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config Lukas Bulwahn
2021-11-11 10:31 ` Fabio Estevam
2021-11-12 16:20 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox