From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Gwendal Grignou <gwendal@chromium.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH v10 3/5] iio: proximity: Add SX9324 support
Date: Sun, 9 Jan 2022 16:39:14 +0000 [thread overview]
Message-ID: <20220109163903.7c368fb2@jic23-huawei> (raw)
In-Reply-To: <CAHp75Ve5OjpdSs3DLvV8PORZMmEz5H+nA=c2Zior-wMTWj0A3w@mail.gmail.com>
On Sun, 9 Jan 2022 14:25:35 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Sun, Jan 2, 2022 at 6:28 PM Gwendal Grignou <gwendal@chromium.org> wrote:
> >
> > Semtech SAR sensor SX9324 is an evolution of the SX9310:
> > It has 4 phases that can be configure to capture and process data
>
> configured
Fixed up.
>
> > from any of 3 CS pins and provide independent detection:
> > proximity, table proximity or body proximity.
>
> ...
>
> > +static const struct acpi_device_id sx9324_acpi_match[] = {
> > + { "STH9324", SX9324_WHOAMI_VALUE },
>
> So I believe this one is allocated by SEMTECH. Can you confirm?
>
This one seemed highly plausible, but indeed good to have it
actually stated that they'd allocated the ID.
> > + { }
> > +};
>
> ...
>
> > +static const struct i2c_device_id sx9324_id[] = {
> > + {"sx9324", SX9324_WHOAMI_VALUE },
>
> Missed space.
Fixed up.
>
> > + { }
> > +};
>
Jonathan
next prev parent reply other threads:[~2022-01-09 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 20:38 [PATCH v10 0/5] Expand Semtech SAR Sensors support Gwendal Grignou
2022-01-01 20:38 ` [PATCH v10 1/5] iio: sx9310: Add frequency in read_avail Gwendal Grignou
2022-01-01 20:38 ` [PATCH v10 2/5] iio: sx9310: Extract common Semtech sensor logic Gwendal Grignou
2022-01-01 20:38 ` [PATCH v10 3/5] iio: proximity: Add SX9324 support Gwendal Grignou
2022-01-09 12:19 ` Andy Shevchenko
2022-01-09 16:41 ` Jonathan Cameron
2022-01-09 12:25 ` Andy Shevchenko
2022-01-09 16:39 ` Jonathan Cameron [this message]
2022-01-09 16:47 ` Andy Shevchenko
2022-01-16 17:01 ` Jonathan Cameron
2022-01-01 20:38 ` [PATCH v10 4/5] dt-bindings: iio: Add sx9324 binding Gwendal Grignou
2022-01-01 20:38 ` [PATCH v10 5/5] iio: sx9324: Add dt_binding support Gwendal Grignou
2022-01-09 10:52 ` [PATCH v10 0/5] Expand Semtech SAR Sensors support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220109163903.7c368fb2@jic23-huawei \
--to=jic23@jic23.retrosnub.co.uk \
--cc=andy.shevchenko@gmail.com \
--cc=gwendal@chromium.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox