Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Gwendal Grignou <gwendal@chromium.org>,
	jongpil19.jung@samsung.com, Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: sx9360: enable push iio event
Date: Sat, 22 Jan 2022 19:14:03 +0000	[thread overview]
Message-ID: <20220122191403.22364523@jic23-huawei> (raw)
In-Reply-To: <CAHp75VcRFRVOPvgGROiNM4wQurTDn+D-DSc0oU1YsrgkkNOF6g@mail.gmail.com>

On Sat, 22 Jan 2022 20:15:57 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Sat, Jan 22, 2022 at 7:23 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > On Tue, 18 Jan 2022 13:25:04 -0800
> > Gwendal Grignou <gwendal@chromium.org> wrote:  
> 
> ...
> 
> > > Fixes: f75095753 ("iio:proximity:sx9360: Add sx9360 support")  
> > This is part of the tag block so should appear.  
> 
> 
> > fixes tag should be here.  
> > > Signed-off-by: Jongpil Jung <jongpil19.jung@samsung.com>
> > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>  
> 
> ...and the submitter's SoB must be last (according to the documentation).
> 
Hi Andy,

If it's a handling chain, rather that about co development etc then
I'd expect it to be in this order to indicate that Gwendal was on the
route to upstream. 

"Any further SoBs (Signed-off-by:'s) following the author's SoB are from
people handling and transporting the patch, but were not involved in its
development. SoB chains should reflect the **real** route a patch took
as it was propagated to the maintainers and ultimately to Linus, with
the first SoB entry signalling primary authorship of a single author."

Jonathan

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Gwendal Grignou <gwendal@chromium.org>,
	jongpil19.jung@samsung.com, Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: sx9360: enable push iio event
Date: Sat, 22 Jan 2022 19:14:24 +0000	[thread overview]
Message-ID: <20220122191403.22364523@jic23-huawei> (raw)
Message-ID: <20220122191424.MnB4bxgB5nDgLMdcSqPLlOU5pw3q_SCm72O48RvrSfA@z> (raw)
In-Reply-To: <CAHp75VcRFRVOPvgGROiNM4wQurTDn+D-DSc0oU1YsrgkkNOF6g@mail.gmail.com>

On Sat, 22 Jan 2022 20:15:57 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Sat, Jan 22, 2022 at 7:23 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > On Tue, 18 Jan 2022 13:25:04 -0800
> > Gwendal Grignou <gwendal@chromium.org> wrote:  
> 
> ...
> 
> > > Fixes: f75095753 ("iio:proximity:sx9360: Add sx9360 support")  
> > This is part of the tag block so should appear.  
> 
> 
> > fixes tag should be here.  
> > > Signed-off-by: Jongpil Jung <jongpil19.jung@samsung.com>
> > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>  
> 
> ...and the submitter's SoB must be last (according to the documentation).
> 
Hi Andy,

If it's a handling chain, rather that about co development etc then
I'd expect it to be in this order to indicate that Gwendal was on the
route to upstream. 

"Any further SoBs (Signed-off-by:'s) following the author's SoB are from
people handling and transporting the patch, but were not involved in its
development. SoB chains should reflect the **real** route a patch took
as it was propagated to the maintainers and ultimately to Linus, with
the first SoB entry signalling primary authorship of a single author."

Jonathan

  reply	other threads:[~2022-01-22 19:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18 21:25 [PATCH] iio: sx9360: enable push iio event Gwendal Grignou
2022-01-22 17:29 ` Jonathan Cameron
2022-01-22 18:15   ` Andy Shevchenko
2022-01-22 19:14     ` Jonathan Cameron [this message]
2022-01-22 19:14       ` Jonathan Cameron
2022-01-24  6:00       ` Gwendal Grignou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220122191403.22364523@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=gwendal@chromium.org \
    --cc=jongpil19.jung@samsung.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox