* [PATCH] iio: accel: adxl367: unlock on error in adxl367_buffer_predisable()
@ 2022-02-24 15:02 Dan Carpenter
2022-02-26 17:58 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-02-24 15:02 UTC (permalink / raw)
To: Lars-Peter Clausen, Cosmin Tanislav
Cc: Michael Hennerich, Jonathan Cameron, linux-iio, kernel-janitors
This error path needs to call the mutex_unlock(&st->lock) before
returning.
Fixes: cbab791c5e2a ("iio: accel: add ADXL367 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/iio/accel/adxl367.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
index b452d74b1d4d..bdc95409abed 100644
--- a/drivers/iio/accel/adxl367.c
+++ b/drivers/iio/accel/adxl367.c
@@ -1359,7 +1359,7 @@ static int adxl367_buffer_predisable(struct iio_dev *indio_dev)
ret = adxl367_set_measure_en(st, true);
if (ret)
- return ret;
+ goto out;
ret = adxl367_set_temp_adc_mask_en(st, indio_dev->active_scan_mask,
false);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: accel: adxl367: unlock on error in adxl367_buffer_predisable()
2022-02-24 15:02 [PATCH] iio: accel: adxl367: unlock on error in adxl367_buffer_predisable() Dan Carpenter
@ 2022-02-26 17:58 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-02-26 17:58 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lars-Peter Clausen, Cosmin Tanislav, Michael Hennerich, linux-iio,
kernel-janitors
On Thu, 24 Feb 2022 18:02:28 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This error path needs to call the mutex_unlock(&st->lock) before
> returning.
>
> Fixes: cbab791c5e2a ("iio: accel: add ADXL367 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to the togreg branch of iio.git.
Jonathan
> ---
> drivers/iio/accel/adxl367.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
> index b452d74b1d4d..bdc95409abed 100644
> --- a/drivers/iio/accel/adxl367.c
> +++ b/drivers/iio/accel/adxl367.c
> @@ -1359,7 +1359,7 @@ static int adxl367_buffer_predisable(struct iio_dev *indio_dev)
>
> ret = adxl367_set_measure_en(st, true);
> if (ret)
> - return ret;
> + goto out;
>
> ret = adxl367_set_temp_adc_mask_en(st, indio_dev->active_scan_mask,
> false);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-26 17:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-24 15:02 [PATCH] iio: accel: adxl367: unlock on error in adxl367_buffer_predisable() Dan Carpenter
2022-02-26 17:58 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox