From: Jonathan Cameron <jic23@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Wei Yongjun <weiyongjun@huaweicloud.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
<linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: ad7124: Silent no spi_device_id warnings
Date: Mon, 19 Sep 2022 16:53:00 +0100 [thread overview]
Message-ID: <20220919165300.71e8012f@jic23-huawei> (raw)
In-Reply-To: <d7afc35d-e764-609c-003c-5ff664649eb4@huawei.com>
On Mon, 19 Sep 2022 22:50:35 +0800
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> On 2022/9/19 22:46, Lars-Peter Clausen wrote:
> > On 9/19/22 16:59, Wei Yongjun wrote:
> >> From: Wei Yongjun <weiyongjun1@huawei.com>
Hi Wei Yongjun,
> >>
> >> Add spi_device_id entries to silent following SPI warnings:
silence rather than silent (also in patch titles)
> >>
> >> SPI driver ad7124 has no spi_device_id for adi,ad7124-4
> >> SPI driver ad7124 has no spi_device_id for adi,ad7124-8
> > What generates those warnings?
> >
>
> Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT
> compatible") added a test to check that every SPI driver has a
> spi_device_id for each DT compatiable string defined by the driver
> and warns if the spi_device_id is missing.
When sending a series of similar fixes to a given subsystem together
it's helpful to group them into a series, so that comments that
apply series wide can easily be easily found.
A cover letter is also useful to provide a little more information on
what is being fixed.
>
> Regards,
> Wei Yongjun
next prev parent reply other threads:[~2022-09-19 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 14:59 [PATCH] iio: adc: ad7124: Silent no spi_device_id warnings Wei Yongjun
2022-09-19 14:46 ` Lars-Peter Clausen
2022-09-19 14:50 ` Wei Yongjun
2022-09-19 15:53 ` Jonathan Cameron [this message]
2022-09-19 15:55 ` Wei Yongjun
2022-09-19 16:05 ` Jonathan Cameron
2022-09-19 14:50 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919165300.71e8012f@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=weiyongjun@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox