Re: [PATCH v4 2/4] HID: hid-sensor-custom: Add LISS custom sensors

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 25 Nov 2022 00:38:39 +0100
Philipp Jungkamp <p.jungkamp@gmx.net> wrote:

> Add the Lenovo Intelligent Sensing Solution (LISS) custom sensors to the
> known custom sensors.
> 
> Signed-off-by: Philipp Jungkamp <p.jungkamp@gmx.net>
Obviously not much to actually review here, beyond 'it looks plausible'.
FWIW

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> 
> v2:
> - Create this 'noop' patch that just adds the LISS sensors to the custom
>   sensor match table.
> 
> v3:
> - Add missing 'Signed-Off-By'
> 
> v4:
> - No change.
> 
>  drivers/hid/hid-sensor-custom.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c
> index 734c6bde68fe..7c6e2e795753 100644
> --- a/drivers/hid/hid-sensor-custom.c
> +++ b/drivers/hid/hid-sensor-custom.c
> @@ -782,6 +782,29 @@ static const struct hid_sensor_custom_match hid_sensor_custom_known_table[] = {
>  		.luid = "020B000000000000",
>  		.manufacturer = "INTEL",
>  	},
> +	/*
> +	 * Lenovo Intelligent Sensing Solution (LISS)
> +	 */
> +	{	/* ambient light */
> +		.tag = "LISS",
> +		.luid = "0041010200000082",
> +		.model = "STK3X3X Sensor",
> +		.manufacturer = "Vendor 258",
> +		.check_dmi = true,
> +		.dmi.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		}
> +	},
> +	{	/* human presence */
> +		.tag = "LISS",
> +		.luid = "0226000171AC0081",
> +		.model = "VL53L1_HOD Sensor",
> +		.manufacturer = "ST_MICRO",
> +		.check_dmi = true,
> +		.dmi.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		}
> +	},
>  	{}
>  };
> 
> --
> 2.38.1
>