Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andrew Hepp <andrew.hepp@ahepp.dev>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: temperature: Add MCP9600 thermocouple EMF converter driver
Date: Thu, 12 Jan 2023 19:05:51 +0000	[thread overview]
Message-ID: <20230112190551.4d9ac5f6@jic23-huawei> (raw)
In-Reply-To: <20230108234503.2803-1-andrew.hepp@ahepp.dev>

On Sun,  8 Jan 2023 15:45:04 -0800
Andrew Hepp <andrew.hepp@ahepp.dev> wrote:

> From: "Andrew Hepp" <andrew.hepp@ahepp.dev>
> 
> Add support for the MCP9600 thermocouple EMF converter.
> 
> Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/MCP960X-Data-Sheet-20005426.pdf
> Signed-off-by: Andrew Hepp <andrew.hepp@ahepp.dev>

Driver looks good, but now I realise we don't have a device tree binding doc.

Please add one for v3.

Note that the binding doc is describing the hardware, not what the driver
currently supports alone, so include the 4 (or 6?) interrupt lines (and interrupt-names
as any random subset of them might be provided) + VDD regulator + anything else I've
not noticed in my 10 second look at the datashet.

Thanks,

Jonathan


  reply	other threads:[~2023-01-12 19:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Jonathan Cameron <jic23@kernel.org>
2023-01-08 23:45 ` [PATCH v2] iio: temperature: Add MCP9600 thermocouple EMF converter driver Andrew Hepp
2023-01-12 19:05   ` Jonathan Cameron [this message]
2023-02-05 15:25     ` Jonathan Cameron
2023-02-07  6:51       ` Andrew Hepp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230112190551.4d9ac5f6@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andrew.hepp@ahepp.dev \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox