Linux IIO development
 help / color / mirror / Atom feed
From: Astrid Rost <astrid.rost@axis.com>
To: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel@axis.com>, Astrid Rost <astrid.rost@axis.com>
Subject: [PATCH v2 1/7] iio: light: vcnl4000: Add proximity irq for vcnl4200
Date: Tue, 9 May 2023 16:01:47 +0200	[thread overview]
Message-ID: <20230509140153.3279288-2-astrid.rost@axis.com> (raw)
In-Reply-To: <20230509140153.3279288-1-astrid.rost@axis.com>

Add proximity interrupt support for vcnl4200 (similar to vcnl4040).
Add support to configure proximity sensor interrupts and threshold
limits. If an interrupt is detected an event will be pushed to the
event interface.

Signed-off-by: Astrid Rost <astrid.rost@axis.com>
---
 drivers/iio/light/vcnl4000.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
index 56d3963d3d66..13568454baff 100644
--- a/drivers/iio/light/vcnl4000.c
+++ b/drivers/iio/light/vcnl4000.c
@@ -65,6 +65,7 @@
 #define VCNL4200_PS_DATA	0x08 /* Proximity data */
 #define VCNL4200_AL_DATA	0x09 /* Ambient light data */
 #define VCNL4040_INT_FLAGS	0x0b /* Interrupt register */
+#define VCNL4200_INT_FLAGS	0x0d /* Interrupt register */
 #define VCNL4200_DEV_ID		0x0e /* Device ID, slave address and version */
 
 #define VCNL4040_DEV_ID		0x0c /* Device ID and version */
@@ -1004,8 +1005,14 @@ static irqreturn_t vcnl4040_irq_thread(int irq, void *p)
 	struct iio_dev *indio_dev = p;
 	struct vcnl4000_data *data = iio_priv(indio_dev);
 	int ret;
+	int reg;
 
-	ret = i2c_smbus_read_word_data(data->client, VCNL4040_INT_FLAGS);
+	if (data->id == VCNL4200)
+		reg = VCNL4200_INT_FLAGS;
+	else
+		reg = VCNL4040_INT_FLAGS;
+
+	ret = i2c_smbus_read_word_data(data->client, reg);
 	if (ret < 0)
 		return IRQ_HANDLED;
 
@@ -1321,9 +1328,10 @@ static const struct vcnl4000_chip_spec vcnl4000_chip_spec_cfg[] = {
 		.measure_light = vcnl4200_measure_light,
 		.measure_proximity = vcnl4200_measure_proximity,
 		.set_power_state = vcnl4200_set_power_state,
-		.channels = vcnl4000_channels,
+		.channels = vcnl4040_channels,
 		.num_channels = ARRAY_SIZE(vcnl4000_channels),
-		.info = &vcnl4000_info,
+		.info = &vcnl4040_info,
+		.irq_thread = vcnl4040_irq_thread,
 	},
 };
 
-- 
2.30.2


  reply	other threads:[~2023-05-09 14:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 14:01 [PATCH v2 0/7] iio: light: vcnl4000: Add features for vncl4040/4200 Astrid Rost
2023-05-09 14:01 ` Astrid Rost [this message]
2023-05-13 18:57   ` [PATCH v2 1/7] iio: light: vcnl4000: Add proximity irq for vcnl4200 Jonathan Cameron
2023-05-09 14:01 ` [PATCH v2 2/7] iio: light: vcnl4000: Add proximity ps_it " Astrid Rost
2023-05-14 17:24   ` Jonathan Cameron
2023-05-09 14:01 ` [PATCH v2 3/7] iio: light: vcnl4000: Add als_it for vcnl4040/4200 Astrid Rost
2023-05-14 17:28   ` Jonathan Cameron
2023-05-09 14:01 ` [PATCH v2 4/7] iio: light: vcnl4000: add illumination irq vcnl4040/4200 Astrid Rost
2023-05-14 17:31   ` Jonathan Cameron
2023-05-09 14:01 ` [PATCH v2 5/7] iio: light: vcnl4000: Add debounce count for vcnl4040/4200 Astrid Rost
2023-05-14 17:37   ` Jonathan Cameron
2023-05-15 15:00     ` Astrid Rost
2023-05-09 14:01 ` [PATCH v2 6/7] iio: light: vcnl4000: Add oversampling_ratio for 4040/4200 Astrid Rost
2023-05-14 17:41   ` Jonathan Cameron
2023-05-15 14:55     ` Astrid Rost
2023-05-09 14:01 ` [PATCH v2 7/7] iio: light: vcnl4000: Add calibration bias " Astrid Rost
2023-05-14 17:44   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230509140153.3279288-2-astrid.rost@axis.com \
    --to=astrid.rost@axis.com \
    --cc=jic23@kernel.org \
    --cc=kernel@axis.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox