From: Astrid Rost <astrid.rost@axis.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@axis.com>, Astrid Rost <astrid.rost@axis.com>
Subject: [PATCH v2 2/7] iio: light: vcnl4000: Add proximity ps_it for vcnl4200
Date: Tue, 9 May 2023 16:01:48 +0200 [thread overview]
Message-ID: <20230509140153.3279288-3-astrid.rost@axis.com> (raw)
In-Reply-To: <20230509140153.3279288-1-astrid.rost@axis.com>
Add ps_it attributes for vcnl4200 (similar to vcnl4040).
Add read/write attribute for proximity integration time.
Read attribute for available proximity integration times.
Change sampling rate depending on integration time.
Signed-off-by: Astrid Rost <astrid.rost@axis.com>
---
drivers/iio/light/vcnl4000.c | 52 +++++++++++++++++++++++++++++++-----
1 file changed, 45 insertions(+), 7 deletions(-)
diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
index 13568454baff..e14475070ac3 100644
--- a/drivers/iio/light/vcnl4000.c
+++ b/drivers/iio/light/vcnl4000.c
@@ -124,6 +124,15 @@ static const int vcnl4040_ps_it_times[][2] = {
{0, 800},
};
+static const int vcnl4200_ps_it_times[][2] = {
+ {0, 96},
+ {0, 144},
+ {0, 192},
+ {0, 384},
+ {0, 768},
+ {0, 864},
+};
+
#define VCNL4000_SLEEP_DELAY_MS 2000 /* before we enter pm_runtime_suspend */
enum vcnl4000_device_ids {
@@ -500,6 +509,16 @@ static int vcnl4000_set_pm_runtime_state(struct vcnl4000_data *data, bool on)
static int vcnl4040_read_ps_it(struct vcnl4000_data *data, int *val, int *val2)
{
int ret;
+ const int(*ps_it_times)[][2];
+ int size;
+
+ if (data->id == VCNL4200) {
+ ps_it_times = &vcnl4200_ps_it_times;
+ size = ARRAY_SIZE(vcnl4200_ps_it_times);
+ } else {
+ ps_it_times = &vcnl4040_ps_it_times;
+ size = ARRAY_SIZE(vcnl4040_ps_it_times);
+ }
ret = i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1);
if (ret < 0)
@@ -507,11 +526,11 @@ static int vcnl4040_read_ps_it(struct vcnl4000_data *data, int *val, int *val2)
ret = FIELD_GET(VCNL4040_PS_CONF2_PS_IT, ret);
- if (ret >= ARRAY_SIZE(vcnl4040_ps_it_times))
+ if (ret >= size)
return -EINVAL;
- *val = vcnl4040_ps_it_times[ret][0];
- *val2 = vcnl4040_ps_it_times[ret][1];
+ *val = (*ps_it_times)[ret][0];
+ *val2 = (*ps_it_times)[ret][1];
return 0;
}
@@ -521,9 +540,19 @@ static ssize_t vcnl4040_write_ps_it(struct vcnl4000_data *data, int val)
unsigned int i;
int ret, index = -1;
u16 regval;
+ const int(*ps_it_times)[][2];
+ int size;
- for (i = 0; i < ARRAY_SIZE(vcnl4040_ps_it_times); i++) {
- if (val == vcnl4040_ps_it_times[i][1]) {
+ if (data->id == VCNL4200) {
+ ps_it_times = &vcnl4200_ps_it_times;
+ size = ARRAY_SIZE(vcnl4200_ps_it_times);
+ } else {
+ ps_it_times = &vcnl4040_ps_it_times;
+ size = ARRAY_SIZE(vcnl4040_ps_it_times);
+ }
+
+ for (i = 0; i < size; i++) {
+ if (val == (*ps_it_times)[i][1]) {
index = i;
break;
}
@@ -532,6 +561,8 @@ static ssize_t vcnl4040_write_ps_it(struct vcnl4000_data *data, int val)
if (index < 0)
return -EINVAL;
+ data->vcnl4200_ps.sampling_rate = ktime_set(0, val * 60000);
+
mutex_lock(&data->vcnl4000_lock);
ret = i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1);
@@ -619,11 +650,18 @@ static int vcnl4040_read_avail(struct iio_dev *indio_dev,
const int **vals, int *type, int *length,
long mask)
{
+ struct vcnl4000_data *data = iio_priv(indio_dev);
+
switch (mask) {
case IIO_CHAN_INFO_INT_TIME:
- *vals = (int *)vcnl4040_ps_it_times;
+ if (data->id == VCNL4200) {
+ *vals = (int *)vcnl4200_ps_it_times;
+ *length = 2 * ARRAY_SIZE(vcnl4200_ps_it_times);
+ } else {
+ *vals = (int *)vcnl4040_ps_it_times;
+ *length = 2 * ARRAY_SIZE(vcnl4040_ps_it_times);
+ }
*type = IIO_VAL_INT_PLUS_MICRO;
- *length = 2 * ARRAY_SIZE(vcnl4040_ps_it_times);
return IIO_AVAIL_LIST;
default:
return -EINVAL;
--
2.30.2
next prev parent reply other threads:[~2023-05-09 14:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 14:01 [PATCH v2 0/7] iio: light: vcnl4000: Add features for vncl4040/4200 Astrid Rost
2023-05-09 14:01 ` [PATCH v2 1/7] iio: light: vcnl4000: Add proximity irq for vcnl4200 Astrid Rost
2023-05-13 18:57 ` Jonathan Cameron
2023-05-09 14:01 ` Astrid Rost [this message]
2023-05-14 17:24 ` [PATCH v2 2/7] iio: light: vcnl4000: Add proximity ps_it " Jonathan Cameron
2023-05-09 14:01 ` [PATCH v2 3/7] iio: light: vcnl4000: Add als_it for vcnl4040/4200 Astrid Rost
2023-05-14 17:28 ` Jonathan Cameron
2023-05-09 14:01 ` [PATCH v2 4/7] iio: light: vcnl4000: add illumination irq vcnl4040/4200 Astrid Rost
2023-05-14 17:31 ` Jonathan Cameron
2023-05-09 14:01 ` [PATCH v2 5/7] iio: light: vcnl4000: Add debounce count for vcnl4040/4200 Astrid Rost
2023-05-14 17:37 ` Jonathan Cameron
2023-05-15 15:00 ` Astrid Rost
2023-05-09 14:01 ` [PATCH v2 6/7] iio: light: vcnl4000: Add oversampling_ratio for 4040/4200 Astrid Rost
2023-05-14 17:41 ` Jonathan Cameron
2023-05-15 14:55 ` Astrid Rost
2023-05-09 14:01 ` [PATCH v2 7/7] iio: light: vcnl4000: Add calibration bias " Astrid Rost
2023-05-14 17:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230509140153.3279288-3-astrid.rost@axis.com \
--to=astrid.rost@axis.com \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox