Re: [PATCH] IIO: hid-sensor-prox: add missing scale attribute

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 14 Oct 2023 19:56:26 -0700
srinivas pandruvada <srinivas.pandruvada@linux.intel.com> wrote:

> On Sat, 2023-10-14 at 17:52 +0100, Jonathan Cameron wrote:
> > On Tue, 8 Aug 2023 14:22:10 +0200
> > Philipp Jungkamp <p.jungkamp@gmx.net> wrote:
> >   
> > > > > The hid-sensor-prox returned an empty string on sysfs
> > > > > in_proximity_scale
> > > > > read. This is due to the the driver's scale never being
> > > > > initialized.    
> > > > 
> > > > What is scale value reporting here? Is it 1.
> > > > 
> > > > Thanks,
> > > > Srinivas    
> > > 
> > > Calling `read` on the sysfs file `in_proximity_scale` returns 0,
> > > thus an empty string.
> > > Adding the hid_format_scale call makes that a '1.000000'.
> > > 
> > > Regards,
> > > Philipp  
> > 
> > Srinivas - I was kind of waiting for a reply to say if you are happy
> > with the explanation.
> > All good?  
> All good.
> 
> Acked-by: Srinivas Pandruvada<srinivas.pandruvada@linux.intel.com>
> 
Given we are late in the cycle and my next fixes pull will probably end up
going in during the merge window anyway, I've applied this to the togreg
branch of iio.git (so the slow path).

Phillipp, if a backport makes sense you can request that after this
goes upstream.

Thanks,

Jonathan

> > 
> > Phillipp - this sounds like a fix to me.  Fixes tag?
> > 
> > Thanks,
> > 
> > Jonathan  
>