From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>,
Philipp Jungkamp <p.jungkamp@gmx.net>
Cc: Jiri Kosina <jikos@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] IIO: hid-sensor-prox: add missing scale attribute
Date: Sat, 14 Oct 2023 19:56:26 -0700 [thread overview]
Message-ID: <32200d0651ba77d03bad5733d8690f9f1b7b8d1a.camel@linux.intel.com> (raw)
In-Reply-To: <20231014175206.6b2ff811@jic23-huawei>
On Sat, 2023-10-14 at 17:52 +0100, Jonathan Cameron wrote:
> On Tue, 8 Aug 2023 14:22:10 +0200
> Philipp Jungkamp <p.jungkamp@gmx.net> wrote:
>
> > > > The hid-sensor-prox returned an empty string on sysfs
> > > > in_proximity_scale
> > > > read. This is due to the the driver's scale never being
> > > > initialized.
> > >
> > > What is scale value reporting here? Is it 1.
> > >
> > > Thanks,
> > > Srinivas
> >
> > Calling `read` on the sysfs file `in_proximity_scale` returns 0,
> > thus an empty string.
> > Adding the hid_format_scale call makes that a '1.000000'.
> >
> > Regards,
> > Philipp
>
> Srinivas - I was kind of waiting for a reply to say if you are happy
> with the explanation.
> All good?
All good.
Acked-by: Srinivas Pandruvada<srinivas.pandruvada@linux.intel.com>
>
> Phillipp - this sounds like a fix to me. Fixes tag?
>
> Thanks,
>
> Jonathan
next prev parent reply other threads:[~2023-10-15 2:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 12:59 [PATCH] IIO: hid-sensor-prox: add missing scale attribute Philipp Jungkamp
2023-08-07 23:02 ` srinivas pandruvada
2023-08-08 12:22 ` Aw: " Philipp Jungkamp
2023-10-14 16:52 ` Jonathan Cameron
2023-10-15 2:56 ` srinivas pandruvada [this message]
2023-10-15 11:04 ` Jonathan Cameron
2023-10-16 7:44 ` Jonathan Cameron
2023-10-16 14:28 ` srinivas pandruvada
2023-10-17 19:11 ` Jonathan Cameron
2023-10-18 1:56 ` srinivas pandruvada
2023-10-28 16:30 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2022-12-22 12:07 Philipp Jungkamp
2022-12-23 14:07 ` Jonathan Cameron
2023-01-02 16:43 ` srinivas pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32200d0651ba77d03bad5733d8690f9f1b7b8d1a.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=p.jungkamp@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox