Re: [PATCH] IIO: hid-sensor-prox: add missing scale attribute

[srinivas pandruvada <srinivas.pandruvada@linux.intel.com>]

On Sun, 2023-08-06 at 14:59 +0200, Philipp Jungkamp wrote:
> The hid-sensor-prox returned an empty string on sysfs
> in_proximity_scale
> read. This is due to the the driver's scale never being initialized.

What is scale value reporting here? Is it 1.

Thanks,
Srinivas

> 
> Try to query the scale of the HID sensor using
> hid_sensor_format_scale.
> 
> Signed-off-by: Philipp Jungkamp <p.jungkamp@gmx.net>
> ---
> Hello,
> 
> up until now I've used the sensor directly through the buffered IIO
> interface,
> ignoring the in_proximity_scale attribute. But while integrating it
> with
> iio-sensor-proxy I noticed that a read on scale return an empty
> string,
> breaking the code there.
> 
> Looking at the code in `hid-sensor-prox.c` it is fairly obvious that
> the scale
> just wasn't being initialized. I now added the
> hid_sensor_format_scale call
> similar to the ones found in e.g. `hid-sensor-als.c`.
> 
> Regards,
> Philipp Jungkamp
> 
>  drivers/iio/light/hid-sensor-prox.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/light/hid-sensor-prox.c
> b/drivers/iio/light/hid-sensor-prox.c
> index a47591e1bad9..aaf2ce6ed52c 100644
> --- a/drivers/iio/light/hid-sensor-prox.c
> +++ b/drivers/iio/light/hid-sensor-prox.c
> @@ -227,6 +227,9 @@ static int prox_parse_report(struct
> platform_device *pdev,
>         dev_dbg(&pdev->dev, "prox %x:%x\n", st->prox_attr.index,
>                         st->prox_attr.report_id);
> 
> +       st->scale_precision = hid_sensor_format_scale(usage_id, &st-
> >prox_attr,
> +                               &st->scale_pre_decml, &st-
> >scale_post_decml);
> +
>         return ret;
>  }
> 
> --
> 2.41.0
>