[PATCH] MAINTAINERS: correct file entry for AD7091R

[PATCH] MAINTAINERS: correct file entry for AD7091R

[Amit Dhingra]

File entry has driver/iio/adc two times. Fix the file entry

Found by ./scripts/get_maintainer.pl --self-test=patterns

Signed-off-by: Amit Dhingra <mechanicalamit@gmail.com>
---
Patch based on jic23/iio.git:togreg branch

I don't think fixes applies here since its not in the mainline yet.

Original patch series Lore link:
https://lore.kernel.org/linux-iio/20231226154509.450c5e40@jic23-huawei/T/#me0d2b8d5ba2f9c46dc8e72ba49b7e6ff14b761c1

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 35147477e8e4..ff61be50e82e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1128,7 +1128,7 @@ L:	linux-iio@vger.kernel.org
 S:	Supported
 W:	http://ez.analog.com/community/linux-device-drivers
 F:	Documentation/devicetree/bindings/iio/adc/adi,ad7091r*
-F:	drivers/iio/adc/drivers/iio/adc/ad7091r*
+F:	drivers/iio/adc/ad7091r*

 ANALOG DEVICES INC AD7192 DRIVER
 M:	Alexandru Tachici <alexandru.tachici@analog.com>
-- 
2.43.0

Re: [PATCH] MAINTAINERS: correct file entry for AD7091R

[Dan Carpenter]

On Sat, Jan 06, 2024 at 12:08:35PM -0800, Amit Dhingra wrote:
> File entry has driver/iio/adc two times. Fix the file entry
> 
> Found by ./scripts/get_maintainer.pl --self-test=patterns
> 
> Signed-off-by: Amit Dhingra <mechanicalamit@gmail.com>
> ---
> Patch based on jic23/iio.git:togreg branch
> 
> I don't think fixes applies here since its not in the mainline yet.
> 

Generally, patches to MAINTAINERS don't need Fixes tags.

It doesn't matter if the patch is in mainline or not.  If it's in a tree
which is rebased then maintainers will fold the fix into the original
commit and the Fixes tag will be lost.  But that's fine.

Also when you're using a Fixes tag, it should all go one one line.
Don't line wrap it at 75 characters.  Just go over the limit.  That's
the normal/correct way.

regards,
dan carpenter

Re: [PATCH] MAINTAINERS: correct file entry for AD7091R

[Amit Dhingra]

On Mon, Jan 08, 2024 at 10:56:02AM +0300, Dan Carpenter wrote:
> Generally, patches to MAINTAINERS don't need Fixes tags.
>
> It doesn't matter if the patch is in mainline or not.  If it's in a tree
> which is rebased then maintainers will fold the fix into the original
> commit and the Fixes tag will be lost.  But that's fine.

Makes sense. Thank you for the information and guidance.
>
> Also when you're using a Fixes tag, it should all go one one line.
> Don't line wrap it at 75 characters.  Just go over the limit.  That's
> the normal/correct way.
Also seems like checkpatch does not like the Fixes line without the
keyword Commit. So the fixes line below generates an Error.

Fixes : 7564efb37346 ("MAINTAINERS: Add entry for TQ-Systems device
trees and drivers")

ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit 7564efb37346 ("MAINTAINERS: Add
entry for TQ-Systems device trees and drivers")'

Adding the keyword commit gives no error.

Documentation shows to use the Fixes tag without the keyword commit.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

>
> regards,
> dan carpenter
>

Re: [PATCH] MAINTAINERS: correct file entry for AD7091R

[Christophe JAILLET]

Le 08/01/2024 à 22:15, Amit Dhingra a écrit :
> On Mon, Jan 08, 2024 at 10:56:02AM +0300, Dan Carpenter wrote:
>> Generally, patches to MAINTAINERS don't need Fixes tags.
>>
>> It doesn't matter if the patch is in mainline or not.  If it's in a tree
>> which is rebased then maintainers will fold the fix into the original
>> commit and the Fixes tag will be lost.  But that's fine.
> 
> Makes sense. Thank you for the information and guidance.
>>
>> Also when you're using a Fixes tag, it should all go one one line.
>> Don't line wrap it at 75 characters.  Just go over the limit.  That's
>> the normal/correct way.
> Also seems like checkpatch does not like the Fixes line without the
> keyword Commit. So the fixes line below generates an Error.
> 
> Fixes : 7564efb37346 ("MAINTAINERS: Add entry for TQ-Systems device

Hi,
try to remove the space after Fixes (i.e. Fixes: 7564efb37346)

CJ

> trees and drivers")
> 
> ERROR: Please use git commit description style 'commit <12+ chars of
> sha1> ("<title line>")' - ie: 'commit 7564efb37346 ("MAINTAINERS: Add
> entry for TQ-Systems device trees and drivers")'
> 
> Adding the keyword commit gives no error.
> 
> Documentation shows to use the Fixes tag without the keyword commit.
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> 
>>
>> regards,
>> dan carpenter
>>
> 
> 

Re: [PATCH] MAINTAINERS: correct file entry for AD7091R

[Amit Dhingra]

On Mon, Jan 08, 2024 at 10:21:51PM +0100, Christophe JAILLET wrote:
> Le 08/01/2024 à 22:15, Amit Dhingra a écrit :
> > On Mon, Jan 08, 2024 at 10:56:02AM +0300, Dan Carpenter wrote:
> > > Generally, patches to MAINTAINERS don't need Fixes tags.
> > >
> > > It doesn't matter if the patch is in mainline or not.  If it's in a tree
> > > which is rebased then maintainers will fold the fix into the original
> > > commit and the Fixes tag will be lost.  But that's fine.
> >
> > Makes sense. Thank you for the information and guidance.
> > >
> > > Also when you're using a Fixes tag, it should all go one one line.
> > > Don't line wrap it at 75 characters.  Just go over the limit.  That's
> > > the normal/correct way.
> > Also seems like checkpatch does not like the Fixes line without the
> > keyword Commit. So the fixes line below generates an Error.
> >
> > Fixes : 7564efb37346 ("MAINTAINERS: Add entry for TQ-Systems device
>
> Hi,
> try to remove the space after Fixes (i.e. Fixes: 7564efb37346)
>
> CJ
>
That worked. Great information. Thank you.

- Amit

Re: [PATCH] MAINTAINERS: correct file entry for AD7091R

[Marcelo Schmitt]

On 01/06, Amit Dhingra wrote:
> File entry has driver/iio/adc two times. Fix the file entry
> 
> Found by ./scripts/get_maintainer.pl --self-test=patterns
> 

Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>

> Signed-off-by: Amit Dhingra <mechanicalamit@gmail.com>
> ---
[...]
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 35147477e8e4..ff61be50e82e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1128,7 +1128,7 @@ L:	linux-iio@vger.kernel.org
>  S:	Supported
>  W:	http://ez.analog.com/community/linux-device-drivers
>  F:	Documentation/devicetree/bindings/iio/adc/adi,ad7091r*
> -F:	drivers/iio/adc/drivers/iio/adc/ad7091r*
> +F:	drivers/iio/adc/ad7091r*
> 
Oops, must have accidentaly bumped the paste key at some point.

Thanks,
Marcelo

Re: [PATCH] MAINTAINERS: correct file entry for AD7091R

[Jonathan Cameron]

On Thu, 11 Jan 2024 22:09:43 -0300
Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:

> On 01/06, Amit Dhingra wrote:
> > File entry has driver/iio/adc two times. Fix the file entry
> > 
> > Found by ./scripts/get_maintainer.pl --self-test=patterns
> >   
> 
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Applied to the togreg branch of iio.git.  I'm not rushing this in as
a fix so it can wait for the next merge window.

Thanks,

Jonathan
> 
> > Signed-off-by: Amit Dhingra <mechanicalamit@gmail.com>
> > ---  
> [...]
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 35147477e8e4..ff61be50e82e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1128,7 +1128,7 @@ L:	linux-iio@vger.kernel.org
> >  S:	Supported
> >  W:	http://ez.analog.com/community/linux-device-drivers
> >  F:	Documentation/devicetree/bindings/iio/adc/adi,ad7091r*
> > -F:	drivers/iio/adc/drivers/iio/adc/ad7091r*
> > +F:	drivers/iio/adc/ad7091r*
> >   
> Oops, must have accidentaly bumped the paste key at some point.
> 
> Thanks,
> Marcelo