Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: Cosmin Tanislav <cosmin.tanislav@analog.com>,
	Mihail Chindris <mihail.chindris@analog.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Tomislav Denis <tomislav.denis@avl.com>,
	Marek Vasut <marex@denx.de>,
	Olivier Moysan <olivier.moysan@foss.st.com>,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Marius Cristea <marius.cristea@microchip.com>,
	Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH v6 3/8] iio: adc: stm32: Fixing err code to not indicate success
Date: Sat, 30 Mar 2024 18:53:00 +0000	[thread overview]
Message-ID: <20240330185305.1319844-4-jic23@kernel.org> (raw)
In-Reply-To: <20240330185305.1319844-1-jic23@kernel.org>

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

This path would result in returning 0 / success on an error path.

Cc: Olivier Moysan <olivier.moysan@foss.st.com>
Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Fixes: 95bc818404b2 ("iio: adc: stm32-adc: add support of generic channels binding")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/adc/stm32-adc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
index b5d3c9cea5c4..283c20757106 100644
--- a/drivers/iio/adc/stm32-adc.c
+++ b/drivers/iio/adc/stm32-adc.c
@@ -2234,6 +2234,7 @@ static int stm32_adc_generic_chan_init(struct iio_dev *indio_dev,
 			if (vin[0] != val || vin[1] >= adc_info->max_channels) {
 				dev_err(&indio_dev->dev, "Invalid channel in%d-in%d\n",
 					vin[0], vin[1]);
+				ret = -EINVAL;
 				goto err;
 			}
 		} else if (ret != -EINVAL) {
-- 
2.44.0


  parent reply	other threads:[~2024-03-30 18:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-30 18:52 [PATCH v6 0/8] IIO: Use device_for_each_child_scope() Jonathan Cameron
2024-03-30 18:52 ` [PATCH v6 1/8] iio: adc: mcp3564: Use device_for_each_child_node_scoped() Jonathan Cameron
2024-03-30 18:52 ` [PATCH v6 2/8] iio: adc: qcom-spmi-adc5: " Jonathan Cameron
2024-04-13  9:36   ` Jonathan Cameron
2024-03-30 18:53 ` Jonathan Cameron [this message]
2024-04-12 12:31   ` [PATCH v6 3/8] iio: adc: stm32: Fixing err code to not indicate success Fabrice Gasnier
2024-04-13  9:37     ` Jonathan Cameron
2024-03-30 18:53 ` [PATCH v6 4/8] iio: adc: stm32: Use device_for_each_child_node_scoped() Jonathan Cameron
2024-04-13  9:38   ` Jonathan Cameron
2024-03-30 18:53 ` [PATCH v6 5/8] iio: adc: ti-ads1015: " Jonathan Cameron
2024-03-30 18:53 ` [PATCH v6 6/8] iio: adc: ti-ads131e08: " Jonathan Cameron
2024-03-30 18:53 ` [PATCH v6 7/8] iio: dac: ad3552r: " Jonathan Cameron
2024-04-04  9:14   ` Nuno Sá
2024-04-06 10:18     ` Jonathan Cameron
2024-03-30 18:53 ` [PATCH v6 8/8] iio: dac: ad5770r: " Jonathan Cameron
2024-04-04  9:11   ` Nuno Sá
2024-04-06 10:19     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240330185305.1319844-4-jic23@kernel.org \
    --to=jic23@kernel.org \
    --cc=Ibrahim.Tilki@analog.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=cosmin.tanislav@analog.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=marex@denx.de \
    --cc=marijn.suijten@somainline.org \
    --cc=marius.cristea@microchip.com \
    --cc=mihail.chindris@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=tomislav.denis@avl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox