Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Vasiliy Doylov via B4 Relay
	<devnull+nekodevelopper.gmail.com@kernel.org>
Cc: nekodevelopper@gmail.com, Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/5] iio: accel: mc3230: add OF match table
Date: Sun, 12 Jan 2025 16:29:17 +0000	[thread overview]
Message-ID: <20250112162917.6f0cfa9f@jic23-huawei> (raw)
In-Reply-To: <20250112-mainlining-mc3510c-v3-3-9ee6520ab69d@gmail.com>

On Sun, 12 Jan 2025 15:25:37 +0300
Vasiliy Doylov via B4 Relay <devnull+nekodevelopper.gmail.com@kernel.org> wrote:

> From: Vasiliy Doylov <nekodevelopper@gmail.com>
> 
> This will make the driver auto loaded via device-tree.
Are you sure that didn't previously work?  I thought there were
fallbacks that would make it use the driver name if nothing else matched.

> 
> Signed-off-by: Vasiliy Doylov <nekodevelopper@gmail.com>
> ---
>  drivers/iio/accel/mc3230.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/accel/mc3230.c b/drivers/iio/accel/mc3230.c
> index a153a3f715ed7f2f1417618715767f265b49191d..ba30c904d3f67002deeb3ca5a7e12bfae312e05f 100644
> --- a/drivers/iio/accel/mc3230.c
> +++ b/drivers/iio/accel/mc3230.c
> @@ -205,9 +205,16 @@ static const struct i2c_device_id mc3230_i2c_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, mc3230_i2c_id);
>  
> +static const struct of_device_id mc3230_of_match[] = {
> +	{ .compatible = "mcube,mc3230" },
> +	{}
{ } 
here as well. 
> +};
> +MODULE_DEVICE_TABLE(of, mc3230_of_match);
> +
>  static struct i2c_driver mc3230_driver = {
>  	.driver = {
>  		.name = "mc3230",
> +		.of_match_table = mc3230_of_match,
>  		.pm = pm_sleep_ptr(&mc3230_pm_ops),
>  	},
>  	.probe		= mc3230_probe,
> 


  reply	other threads:[~2025-01-12 16:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-12 12:25 [PATCH v3 0/5] iio: accel: mc3230: add mount matrix, of match and mc3510c support Vasiliy Doylov via B4 Relay
2025-01-12 12:25 ` [PATCH v3 1/5] dt-bindings: iio: accel: mc3230: document mc3510c Vasiliy Doylov via B4 Relay
2025-01-13  8:49   ` Krzysztof Kozlowski
2025-01-12 12:25 ` [PATCH v3 2/5] iio: accel: mc3230: add mount matrix support Vasiliy Doylov via B4 Relay
2025-01-12 16:28   ` Jonathan Cameron
2025-01-12 12:25 ` [PATCH v3 3/5] iio: accel: mc3230: add OF match table Vasiliy Doylov via B4 Relay
2025-01-12 16:29   ` Jonathan Cameron [this message]
2025-01-12 16:38     ` Vasiliy Doylov
2025-01-12 12:25 ` [PATCH v3 4/5] iio: accel: mc3230: add multiple devices support Vasiliy Doylov via B4 Relay
2025-01-12 16:32   ` Jonathan Cameron
2025-01-13  8:51   ` Krzysztof Kozlowski
2025-01-12 12:25 ` [PATCH v3 5/5] iio: accel: mc3230: add mc3510c support Vasiliy Doylov via B4 Relay
2025-01-12 16:34   ` Jonathan Cameron
2025-01-13  8:51   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250112162917.6f0cfa9f@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+nekodevelopper.gmail.com@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nekodevelopper@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox