Re: [PATCH v3 5/5] iio: accel: mc3230: add mc3510c support

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 12 Jan 2025 15:25:39 +0300
Vasiliy Doylov via B4 Relay <devnull+nekodevelopper.gmail.com@kernel.org> wrote:

> From: Vasiliy Doylov <nekodevelopper@gmail.com>
> 
> This commit integrates support for the mc3510c into the mc3230 driver.
> 
> Tested on Huawei MediaPad T3 10 (huawei-agassi)
> 
> Signed-off-by: Vasiliy Doylov <nekodevelopper@gmail.com>
Looks good to me.

If nothing else comes up in review you can either send a v4 with the
minor things I mentioned, or I'll just pick this up and tweak it whilst
applying.  For now it should stay on list for a few days for other people
to comment on if they wish and the trivial-devices entry to get reviewed.

Thanks,

Jonathan

> ---
>  drivers/iio/accel/mc3230.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/iio/accel/mc3230.c b/drivers/iio/accel/mc3230.c
> index 1b58f3ea50655b6563a78a2531b16a8088e8f8d5..92934975edc77b11ed6dc3da077a28d317314fab 100644
> --- a/drivers/iio/accel/mc3230.c
> +++ b/drivers/iio/accel/mc3230.c
> @@ -46,6 +46,14 @@ static struct mc3230_chip_info mc3230_chip_info = {
>  	.scale = 115411765,
>  };
>  
> +static struct mc3230_chip_info mc3510c_chip_info = {
> +	.chip_id = 0x23,
> +	.name = "mc3510c",
> +	.product_code = 0x10,
> +	/* Was obtained empirically */
> +	.scale = 625000000,
> +};
> +
>  #define MC3230_CHANNEL(reg, axis) {	\
>  	.type = IIO_ACCEL,	\
>  	.address = reg,	\
> @@ -225,12 +233,14 @@ static DEFINE_SIMPLE_DEV_PM_OPS(mc3230_pm_ops, mc3230_suspend, mc3230_resume);
>  
>  static const struct i2c_device_id mc3230_i2c_id[] = {
>  	{ "mc3230", (kernel_ulong_t)&mc3230_chip_info },
> +	{ "mc3510c", (kernel_ulong_t)&mc3510c_chip_info },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(i2c, mc3230_i2c_id);
>  
>  static const struct of_device_id mc3230_of_match[] = {
>  	{ .compatible = "mcube,mc3230", &mc3230_chip_info },
> +	{ .compatible = "mcube,mc3510c", &mc3510c_chip_info },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, mc3230_of_match);
>