[PATCH] iio: adc: Kconfig: add kfifo dependency to fix module build

[PATCH] iio: adc: Kconfig: add kfifo dependency to fix module build

[r2.arthur.prince]

From: Arthur-Prince <r2.arthur.prince@gmail.com>

Add dependency to Kconfig’s ti-ads1298 because compiling it as a module
failed with an undefined kfifo symbol.

Fixes: 00ef7708fa6 ("iio: adc: ti-ads1298: Add driver")
Signed-off-by: Arthur-Prince <r2.arthur.prince@gmail.com>
Co-developed-by: Mariana Valério <mariana.valerio2@hotmail.com>
Signed-off-by: Mariana Valério <mariana.valerio2@hotmail.com>
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 849c90203071..513f2238fdee 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -1492,6 +1492,7 @@ config TI_ADS1298
 	tristate "Texas Instruments ADS1298"
 	depends on SPI
 	select IIO_BUFFER
+	select IIO_KFIFO_BUF
 	help
 	  If you say yes here you get support for Texas Instruments ADS1298
 	  medical ADC chips
-- 
2.45.2

Re: [PATCH] iio: adc: Kconfig: add kfifo dependency to fix module build

[Jonathan Cameron]

On Wed, 30 Apr 2025 16:07:37 -0300
r2.arthur.prince@gmail.com wrote:

> From: Arthur-Prince <r2.arthur.prince@gmail.com>
> 
> Add dependency to Kconfig’s ti-ads1298 because compiling it as a module
> failed with an undefined kfifo symbol.
> 
> Fixes: 00ef7708fa6 ("iio: adc: ti-ads1298: Add driver")
> Signed-off-by: Arthur-Prince <r2.arthur.prince@gmail.com>
> Co-developed-by: Mariana Valério <mariana.valerio2@hotmail.com>
> Signed-off-by: Mariana Valério <mariana.valerio2@hotmail.com>
Applied and marked for stable

> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 849c90203071..513f2238fdee 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -1492,6 +1492,7 @@ config TI_ADS1298
>  	tristate "Texas Instruments ADS1298"
>  	depends on SPI
>  	select IIO_BUFFER
> +	select IIO_KFIFO_BUF
>  	help
>  	  If you say yes here you get support for Texas Instruments ADS1298
>  	  medical ADC chips

Re: [PATCH] iio: adc: Kconfig: add kfifo dependency to fix module build

[Jonathan Cameron]

On Sun, 4 May 2025 17:46:43 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Wed, 30 Apr 2025 16:07:37 -0300
> r2.arthur.prince@gmail.com wrote:
> 
> > From: Arthur-Prince <r2.arthur.prince@gmail.com>
> > 
> > Add dependency to Kconfig’s ti-ads1298 because compiling it as a module
> > failed with an undefined kfifo symbol.
> > 
> > Fixes: 00ef7708fa6 ("iio: adc: ti-ads1298: Add driver")
> > Signed-off-by: Arthur-Prince <r2.arthur.prince@gmail.com>
> > Co-developed-by: Mariana Valério <mariana.valerio2@hotmail.com>
> > Signed-off-by: Mariana Valério <mariana.valerio2@hotmail.com>  
> Applied and marked for stable

So we had a clash between this which was in the fixes-togreg branch
with a tidy up of ordering that was in the togreg branch.

Given this wasn't a new bug, I've shifted this to the togreg branch so
I could resolve this without much mess (the ordering patch was way down
my togreg branch whereas this was near the top of the fixes one)

Slight delay in this fix getting upstream as a result.

Jonathan

> 
> > ---
> >  drivers/iio/adc/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index 849c90203071..513f2238fdee 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -1492,6 +1492,7 @@ config TI_ADS1298
> >  	tristate "Texas Instruments ADS1298"
> >  	depends on SPI
> >  	select IIO_BUFFER
> > +	select IIO_KFIFO_BUF
> >  	help
> >  	  If you say yes here you get support for Texas Instruments ADS1298
> >  	  medical ADC chips  
> 
>