* [PATCH] iio: adc: ad7380: remove unused oversampling_ratio getter
@ 2025-06-24 22:44 David Lechner
2025-06-27 15:56 ` Nuno Sá
0 siblings, 1 reply; 3+ messages in thread
From: David Lechner @ 2025-06-24 22:44 UTC (permalink / raw)
To: Michael Hennerich, Nuno Sá, Jonathan Cameron,
Andy Shevchenko
Cc: linux-iio, linux-kernel, David Lechner
Remove a call to ad7380_get_osr() in ad7380_init_offload_msg. The
returned value is never used.
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
I wrote this a while back but it looks like it never got sent so here
it is now.
---
drivers/iio/adc/ad7380.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c
index d96bd12dfea632b62475d6537c8d6601b042de1f..abcd4cc70074723303b9b67e2b89b0c4b43c6884 100644
--- a/drivers/iio/adc/ad7380.c
+++ b/drivers/iio/adc/ad7380.c
@@ -1165,7 +1165,6 @@ static int ad7380_init_offload_msg(struct ad7380_state *st,
struct spi_transfer *xfer = &st->offload_xfer;
struct device *dev = &st->spi->dev;
const struct iio_scan_type *scan_type;
- int oversampling_ratio;
int ret;
scan_type = iio_get_current_scan_type(indio_dev,
@@ -1195,10 +1194,6 @@ static int ad7380_init_offload_msg(struct ad7380_state *st,
}
}
- ret = ad7380_get_osr(st, &oversampling_ratio);
- if (ret)
- return ret;
-
xfer->bits_per_word = scan_type->realbits;
xfer->offload_flags = SPI_OFFLOAD_XFER_RX_STREAM;
xfer->len = AD7380_SPI_BYTES(scan_type) * st->chip_info->num_simult_channels;
---
base-commit: b57cb7c47e31244bef6612f271c5dc390f761e17
change-id: 20250624-iio-adc-ad7380-remove-unused-oversampling_ratio-getter-e54413627fe0
Best regards,
--
David Lechner <dlechner@baylibre.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: ad7380: remove unused oversampling_ratio getter
2025-06-24 22:44 [PATCH] iio: adc: ad7380: remove unused oversampling_ratio getter David Lechner
@ 2025-06-27 15:56 ` Nuno Sá
2025-06-28 15:30 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Nuno Sá @ 2025-06-27 15:56 UTC (permalink / raw)
To: David Lechner, Michael Hennerich, Nuno Sá, Jonathan Cameron,
Andy Shevchenko
Cc: linux-iio, linux-kernel
On Tue, 2025-06-24 at 22:44 +0000, David Lechner wrote:
> Remove a call to ad7380_get_osr() in ad7380_init_offload_msg. The
> returned value is never used.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> I wrote this a while back but it looks like it never got sent so here
> it is now.
> ---
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> drivers/iio/adc/ad7380.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c
> index
> d96bd12dfea632b62475d6537c8d6601b042de1f..abcd4cc70074723303b9b67e2b89b0c4b43c
> 6884 100644
> --- a/drivers/iio/adc/ad7380.c
> +++ b/drivers/iio/adc/ad7380.c
> @@ -1165,7 +1165,6 @@ static int ad7380_init_offload_msg(struct ad7380_state
> *st,
> struct spi_transfer *xfer = &st->offload_xfer;
> struct device *dev = &st->spi->dev;
> const struct iio_scan_type *scan_type;
> - int oversampling_ratio;
> int ret;
>
> scan_type = iio_get_current_scan_type(indio_dev,
> @@ -1195,10 +1194,6 @@ static int ad7380_init_offload_msg(struct ad7380_state
> *st,
> }
> }
>
> - ret = ad7380_get_osr(st, &oversampling_ratio);
> - if (ret)
> - return ret;
> -
> xfer->bits_per_word = scan_type->realbits;
> xfer->offload_flags = SPI_OFFLOAD_XFER_RX_STREAM;
> xfer->len = AD7380_SPI_BYTES(scan_type) * st->chip_info-
> >num_simult_channels;
>
> ---
> base-commit: b57cb7c47e31244bef6612f271c5dc390f761e17
> change-id: 20250624-iio-adc-ad7380-remove-unused-oversampling_ratio-getter-
> e54413627fe0
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: ad7380: remove unused oversampling_ratio getter
2025-06-27 15:56 ` Nuno Sá
@ 2025-06-28 15:30 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2025-06-28 15:30 UTC (permalink / raw)
To: Nuno Sá
Cc: David Lechner, Michael Hennerich, Nuno Sá, Andy Shevchenko,
linux-iio, linux-kernel
On Fri, 27 Jun 2025 16:56:55 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Tue, 2025-06-24 at 22:44 +0000, David Lechner wrote:
> > Remove a call to ad7380_get_osr() in ad7380_init_offload_msg. The
> > returned value is never used.
> >
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > ---
> > I wrote this a while back but it looks like it never got sent so here
> > it is now.
> > ---
>
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-28 15:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-24 22:44 [PATCH] iio: adc: ad7380: remove unused oversampling_ratio getter David Lechner
2025-06-27 15:56 ` Nuno Sá
2025-06-28 15:30 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox