From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Gustavo Silva <gustavograzs@gmail.com>,
lanzano.alex@gmail.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/4] iio: ABI: document accel and roc event attributes
Date: Sat, 30 Aug 2025 18:05:34 +0100 [thread overview]
Message-ID: <20250830180534.24a8ad56@jic23-huawei> (raw)
In-Reply-To: <CAHp75Vf13aqDJj2j7MtfLTAT2MW-S3+M7wtEXsG1Wh7EKfxJSQ@mail.gmail.com>
On Sat, 30 Aug 2025 15:49:50 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Sat, Aug 30, 2025 at 2:58 PM Gustavo Silva <gustavograzs@gmail.com> wrote:
> >
> > Add accelerometer and rate of change event-related sysfs attributes
> > exposed by the bmi270 driver.
>
> Seems to me like the absent attributes that are already in the kernel,
> should be added in the separate patch.
Agreed that would be ideal.
>
> ...
>
> > +What: /sys/.../iio:deviceX/events/in_accel_x&y&z_roc_rising_en
>
> Out of curiosity, is it for real? I mean & (ampersand) in the sysfs
> attribute name? This is quite inconvenient for use in shells.
Yup.
Easy enough to escape...
It's really wordy to express boolean relationships without using symbols.
This has been in the ABI all the way back to the beginning I think.
Jonathan
>
next prev parent reply other threads:[~2025-08-30 17:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 11:58 [PATCH v5 0/4] BMI270: Add support for step counter and motion events Gustavo Silva
2025-08-30 11:58 ` [PATCH v5 3/4] iio: imu: bmi270: add support for " Gustavo Silva
2025-08-30 12:44 ` Andy Shevchenko
2025-08-30 12:47 ` Andy Shevchenko
2025-08-30 17:00 ` Jonathan Cameron
2025-09-13 12:46 ` Gustavo Silva
2025-09-14 11:40 ` Andy Shevchenko
2025-08-30 11:58 ` [PATCH v5 4/4] iio: ABI: document accel and roc event attributes Gustavo Silva
2025-08-30 12:49 ` Andy Shevchenko
2025-08-30 17:05 ` Jonathan Cameron [this message]
2025-08-30 17:09 ` Jonathan Cameron
2025-08-30 19:58 ` Andy Shevchenko
2025-08-31 15:39 ` Jonathan Cameron
2025-08-30 17:21 ` Jonathan Cameron
2025-08-30 12:36 ` [PATCH v5 0/4] BMI270: Add support for step counter and motion events Andy Shevchenko
2025-08-30 17:23 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250830180534.24a8ad56@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavograzs@gmail.com \
--cc=lanzano.alex@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox