Re: [PATCH v5 4/4] iio: ABI: document accel and roc event attributes

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 30 Aug 2025 18:05:34 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Sat, 30 Aug 2025 15:49:50 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> 
> > On Sat, Aug 30, 2025 at 2:58 PM Gustavo Silva <gustavograzs@gmail.com> wrote:  
> > >
> > > Add accelerometer and rate of change event-related sysfs attributes
> > > exposed by the bmi270 driver.    
> > 
> > Seems to me like the absent attributes that are already in the kernel,
> > should be added in the separate patch.  
> Agreed that would be ideal.

Actually what did you mean by absent attributes? 

This is documenting ABI that is part of the general 'scope' of the full
IIO ABI but which hasn't turned up before in this particular combination
(or possibly we missed updating docs when it did!)

Whether it is worth separating out any we know are in another driver is
an open question, but Gustavo hasn't called out any as being like that.
It's possible that these are all surfacing for the first time in this driver.

Jonathan

> > 
> > ...
> >   
> > > +What:          /sys/.../iio:deviceX/events/in_accel_x&y&z_roc_rising_en    
> > 
> > Out of curiosity, is it for real? I mean & (ampersand) in the sysfs
> > attribute name? This is quite inconvenient for use in shells.  
> 
> Yup.
> 
> Easy enough to escape...
> 
> It's really wordy to express boolean relationships without using symbols.
> This has been in the ABI all the way back to the beginning I think.
> 
> Jonathan
> 
> >   
>