[PATCH] iio: adc: ad7768-1: Select GPIOLIB

[PATCH] iio: adc: ad7768-1: Select GPIOLIB

[Jonathan Cameron]

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

This driver provides a gpio chip a some related functions are not
stubbed if GPIOLIB is not built.

   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_get':
>> drivers/iio/adc/ad7768-1.c:420: undefined reference to `gpiochip_get_data'
   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_set':
   drivers/iio/adc/ad7768-1.c:453: undefined reference to `gpiochip_get_data'
   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_init':
>> drivers/iio/adc/ad7768-1.c:498: undefined reference to `devm_gpiochip_add_data_with_key'
   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_input':
   drivers/iio/adc/ad7768-1.c:387: undefined reference to `gpiochip_get_data'
   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_output':
   drivers/iio/adc/ad7768-1.c:404: undefined reference to `gpiochip_get_data'

Fixes: ("d569ae0f052e iio: adc: ad7768-1: Add GPIO controller support")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202512271235.WwAmAbOa-lkp@intel.com/
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index b4295aa415bf..e37569f65524 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -409,6 +409,7 @@ config AD7766
 config AD7768_1
 	tristate "Analog Devices AD7768-1 ADC driver"
 	depends on SPI
+	select GPIOLIB
 	select REGULATOR
 	select REGMAP_SPI
 	select IIO_BUFFER
-- 
2.52.0

Re: [PATCH] iio: adc: ad7768-1: Select GPIOLIB

[Andy Shevchenko]

On Sun, Jan 11, 2026 at 04:55:28PM +0000, Jonathan Cameron wrote:

Thanks for fixing this, my comment below.

> This driver provides a gpio chip a some related functions are not
> stubbed if GPIOLIB is not built.
> 
>    hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_get':
> >> drivers/iio/adc/ad7768-1.c:420: undefined reference to `gpiochip_get_data'
>    hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_set':
>    drivers/iio/adc/ad7768-1.c:453: undefined reference to `gpiochip_get_data'
>    hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_init':
> >> drivers/iio/adc/ad7768-1.c:498: undefined reference to `devm_gpiochip_add_data_with_key'
>    hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_input':
>    drivers/iio/adc/ad7768-1.c:387: undefined reference to `gpiochip_get_data'
>    hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_output':
>    drivers/iio/adc/ad7768-1.c:404: undefined reference to `gpiochip_get_data'

We don't need these many strings, the important ones only would be enough, like

  ad7768-1.c:420: undefined reference to `gpiochip_get_data'
  ad7768-1.c:498: undefined reference to `devm_gpiochip_add_data_with_key'

(and also no need to have a full path in this case, we can always read an email
 from the LKP below).

> Fixes: ("d569ae0f052e iio: adc: ad7768-1: Add GPIO controller support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512271235.WwAmAbOa-lkp@intel.com/
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: adc: ad7768-1: Select GPIOLIB

[David Lechner]

On 1/11/26 10:55 AM, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> This driver provides a gpio chip a some related functions are not
I think you mean "chip and ..."