[PATCH v1 1/1] iio: buffer: Move from int64_t to s64 for timestamp

[PATCH v1 1/1] iio: buffer: Move from int64_t to s64 for timestamp

[Andy Shevchenko]

iio_push_to_buffers_with_ts_unaligned() uses int64_t for timestamp.
Move it from int64_t to s64 to make consistent with:
- iio_push_to_buffers_with_ts()
- all current users that supply s64 anyway

This will reduce potential of wrong type being chosen when using
this API.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/iio/industrialio-buffer.c | 2 +-
 include/linux/iio/buffer.h        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index 46f36a6ed271..6d92295422be 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -2422,7 +2422,7 @@ EXPORT_SYMBOL_GPL(iio_push_to_buffers);
 int iio_push_to_buffers_with_ts_unaligned(struct iio_dev *indio_dev,
 					  const void *data,
 					  size_t data_sz,
-					  int64_t timestamp)
+					  s64 timestamp)
 {
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
 
diff --git a/include/linux/iio/buffer.h b/include/linux/iio/buffer.h
index d37f82678f71..e0344d51b4f9 100644
--- a/include/linux/iio/buffer.h
+++ b/include/linux/iio/buffer.h
@@ -71,7 +71,7 @@ static inline int iio_push_to_buffers_with_ts(struct iio_dev *indio_dev,
 
 int iio_push_to_buffers_with_ts_unaligned(struct iio_dev *indio_dev,
 					  const void *data, size_t data_sz,
-					  int64_t timestamp);
+					  s64 timestamp);
 
 bool iio_validate_scan_mask_onehot(struct iio_dev *indio_dev,
 				   const unsigned long *mask);
-- 
2.50.1

Re: [PATCH v1 1/1] iio: buffer: Move from int64_t to s64 for timestamp

[Jonathan Cameron]

On Mon, 27 Apr 2026 20:51:47 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> iio_push_to_buffers_with_ts_unaligned() uses int64_t for timestamp.
> Move it from int64_t to s64 to make consistent with:
> - iio_push_to_buffers_with_ts()
> - all current users that supply s64 anyway
> 
> This will reduce potential of wrong type being chosen when using
> this API.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I was being overly optimistic and thinking we'd get rid of this ABI by
now so not worth fixing.  That's going a bit slow, so fair enough.

Applied.

Thanks,

Jonathan

> ---
>  drivers/iio/industrialio-buffer.c | 2 +-
>  include/linux/iio/buffer.h        | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index 46f36a6ed271..6d92295422be 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -2422,7 +2422,7 @@ EXPORT_SYMBOL_GPL(iio_push_to_buffers);
>  int iio_push_to_buffers_with_ts_unaligned(struct iio_dev *indio_dev,
>  					  const void *data,
>  					  size_t data_sz,
> -					  int64_t timestamp)
> +					  s64 timestamp)
>  {
>  	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
>  
> diff --git a/include/linux/iio/buffer.h b/include/linux/iio/buffer.h
> index d37f82678f71..e0344d51b4f9 100644
> --- a/include/linux/iio/buffer.h
> +++ b/include/linux/iio/buffer.h
> @@ -71,7 +71,7 @@ static inline int iio_push_to_buffers_with_ts(struct iio_dev *indio_dev,
>  
>  int iio_push_to_buffers_with_ts_unaligned(struct iio_dev *indio_dev,
>  					  const void *data, size_t data_sz,
> -					  int64_t timestamp);
> +					  s64 timestamp);
>  
>  bool iio_validate_scan_mask_onehot(struct iio_dev *indio_dev,
>  				   const unsigned long *mask);