[PATCH v5] iio: humidity: ens210: Fix missing I2C functionality checks

[PATCH v5] iio: humidity: ens210: Fix missing I2C functionality checks

[Salah Triki]

The ENS210 driver uses SMBus transactions (such as byte, word, and block
data reads/writes) during the probe and measurement phases. However, the
initial functionality check only validated a subset of these capabilities,
which could lead to loading failures on adapters requiring SMBus
emulation or native-only controllers.

To ensure compatibility across a wide range of I2C adapters, modify the
functionality check to verify if the adapter supports the required native
operations or, failing that, supports the SMBus emulation layer.

Fixes: c524fbca672e ("iio: humidity: Add support for ENS210")
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
Changes since v4:
- Fixed the alignment and indentation of the I2C functionality check
  per Andy's review.

Changes since v3:
- Fixed the alignment and indentation of the I2C functionality check
  per Andy's review.

Changes since v2:
- Fixed the alignment and indentation of the I2C functionality check
  per Maxime's review.

Changes since v1:
- Updated the I2C functionality test to check for both required native
  operations and SMBus emulation (`I2C_FUNC_SMBUS_EMUL`) to prevent
  loading issues on controllers lacking the emulation flag.

 drivers/iio/humidity/ens210.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/humidity/ens210.c b/drivers/iio/humidity/ens210.c
index 77418d97f30d..159a3c158c9f 100644
--- a/drivers/iio/humidity/ens210.c
+++ b/drivers/iio/humidity/ens210.c
@@ -204,7 +204,10 @@ static int ens210_probe(struct i2c_client *client)
 	if (!i2c_check_functionality(client->adapter,
 				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
 				     I2C_FUNC_SMBUS_WRITE_BYTE |
-				     I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
+				     I2C_FUNC_SMBUS_READ_BYTE_DATA |
+				     I2C_FUNC_SMBUS_READ_WORD_DATA |
+				     I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
+	    !i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {
 		return dev_err_probe(&client->dev, -EOPNOTSUPP,
 			"adapter does not support some i2c transactions\n");
 	}
-- 
2.43.0

Re: [PATCH v5] iio: humidity: ens210: Fix missing I2C functionality checks

[Joshua Crofts]

On Wed, 6 May 2026 at 12:13, Salah Triki <salah.triki@gmail.com> wrote:
>
> The ENS210 driver uses SMBus transactions (such as byte, word, and block
> data reads/writes) during the probe and measurement phases. However, the
> initial functionality check only validated a subset of these capabilities,
> which could lead to loading failures on adapters requiring SMBus
> emulation or native-only controllers.
>
> To ensure compatibility across a wide range of I2C adapters, modify the
> functionality check to verify if the adapter supports the required native
> operations or, failing that, supports the SMBus emulation layer.
>
> Fixes: c524fbca672e ("iio: humidity: Add support for ENS210")
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---

Please slow down, you've sent two versions in the past 30 minutes.

Alignment is fine, but refrain from sending patches that quickly.

-- 
Kind regards

CJD

Re: [PATCH v5] iio: humidity: ens210: Fix missing I2C functionality checks

[Jonathan Cameron]

On Wed, 6 May 2026 12:17:42 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Wed, 6 May 2026 at 12:13, Salah Triki <salah.triki@gmail.com> wrote:
> >
> > The ENS210 driver uses SMBus transactions (such as byte, word, and block
> > data reads/writes) during the probe and measurement phases. However, the
> > initial functionality check only validated a subset of these capabilities,
> > which could lead to loading failures on adapters requiring SMBus
> > emulation or native-only controllers.
> >
> > To ensure compatibility across a wide range of I2C adapters, modify the
> > functionality check to verify if the adapter supports the required native
> > operations or, failing that, supports the SMBus emulation layer.
> >
> > Fixes: c524fbca672e ("iio: humidity: Add support for ENS210")
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---  
> 
> Please slow down, you've sent two versions in the past 30 minutes.
> 
> Alignment is fine, but refrain from sending patches that quickly.
> 
The comments I just sent indeed applied to v2... So good advice
that you should slow down!

J

Re: [PATCH v5] iio: humidity: ens210: Fix missing I2C functionality checks

[Andy Shevchenko]

On Wed, May 06, 2026 at 10:58:35AM +0100, Salah Triki wrote:
> The ENS210 driver uses SMBus transactions (such as byte, word, and block
> data reads/writes) during the probe and measurement phases. However, the
> initial functionality check only validated a subset of these capabilities,
> which could lead to loading failures on adapters requiring SMBus
> emulation or native-only controllers.
> 
> To ensure compatibility across a wide range of I2C adapters, modify the
> functionality check to verify if the adapter supports the required native
> operations or, failing that, supports the SMBus emulation layer.

As Joshua said, next time respect the rules, id est no new version for at
least 24h+ period of time. Give others chance to review.

This one, although, is small,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v5] iio: humidity: ens210: Fix missing I2C functionality checks

[Jonathan Cameron]

On Wed,  6 May 2026 10:58:35 +0100
Salah Triki <salah.triki@gmail.com> wrote:

> The ENS210 driver uses SMBus transactions (such as byte, word, and block
> data reads/writes) during the probe and measurement phases. However, the
> initial functionality check only validated a subset of these capabilities,
> which could lead to loading failures on adapters requiring SMBus
> emulation or native-only controllers.
> 
> To ensure compatibility across a wide range of I2C adapters, modify the
> functionality check to verify if the adapter supports the required native
> operations or, failing that, supports the SMBus emulation layer.
> 
> Fixes: c524fbca672e ("iio: humidity: Add support for ENS210")
Are there any known i2c adapters that this actually applies to?
Feels to me like hardening against unexpected results rather than a
real fix.  So probably drop the tag.
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
> Changes since v4:
> - Fixed the alignment and indentation of the I2C functionality check
>   per Andy's review.
> 
> Changes since v3:
> - Fixed the alignment and indentation of the I2C functionality check
>   per Andy's review.
> 
> Changes since v2:
> - Fixed the alignment and indentation of the I2C functionality check
>   per Maxime's review.
> 
> Changes since v1:
> - Updated the I2C functionality test to check for both required native
>   operations and SMBus emulation (`I2C_FUNC_SMBUS_EMUL`) to prevent
>   loading issues on controllers lacking the emulation flag.
That one is spurious. See below. A device on a bus doesn't care
how these bus operations are occurring so should never be messing
with that define.

> 
>  drivers/iio/humidity/ens210.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/humidity/ens210.c b/drivers/iio/humidity/ens210.c
> index 77418d97f30d..159a3c158c9f 100644
> --- a/drivers/iio/humidity/ens210.c
> +++ b/drivers/iio/humidity/ens210.c
> @@ -204,7 +204,10 @@ static int ens210_probe(struct i2c_client *client)
>  	if (!i2c_check_functionality(client->adapter,
>  				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
>  				     I2C_FUNC_SMBUS_WRITE_BYTE |
> -				     I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
> +				     I2C_FUNC_SMBUS_READ_BYTE_DATA |
> +				     I2C_FUNC_SMBUS_READ_WORD_DATA |
> +				     I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
Look at definitions of:
I2C_FUNC_SMBUS_BYTE_DATA and I2C_FUNC_SMUS_WORD_DATA

As you might imagine it's common to want the pairs or read and write
so there are macros for it.


> +	    !i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {
I don't follow the point in this check. See how I2C_FUNC_SMBUS_EMUL is defined
#define I2C_FUNC_SMBUS_EMUL		(I2C_FUNC_SMBUS_QUICK | \
					 I2C_FUNC_SMBUS_BYTE | \
					 I2C_FUNC_SMBUS_BYTE_DATA | \
					 I2C_FUNC_SMBUS_WORD_DATA | \
					 I2C_FUNC_SMBUS_PROC_CALL | \
					 I2C_FUNC_SMBUS_WRITE_BLOCK_DATA | \
					 I2C_FUNC_SMBUS_I2C_BLOCK | \
					 I2C_FUNC_SMBUS_PEC)


So if that passes the earlier one already passed as it's a subset.


>  		return dev_err_probe(&client->dev, -EOPNOTSUPP,
>  			"adapter does not support some i2c transactions\n");
>  	}