* [PATCH] iio: accel: adxl355: replace usleep_range() with fsleep()
@ 2026-05-10 5:08 Stepan Ionichev
2026-05-10 5:53 ` [PATCH v2] " Stepan Ionichev
2026-05-10 12:54 ` [PATCH] " Andy Shevchenko
0 siblings, 2 replies; 4+ messages in thread
From: Stepan Ionichev @ 2026-05-10 5:08 UTC (permalink / raw)
To: jic23
Cc: lars, Michael.Hennerich, puranjay, dlechner, nuno.sa, andy,
linux-iio, linux-kernel, sozdayvek
The "at least 5ms" wait after software reset has no specific upper
bound. Switch to fsleep() which is the kernel helper for plain
"about N microseconds" delays.
No functional change.
Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
---
drivers/iio/accel/adxl355_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_core.c
index 8f90c58f4..594c8ad93 100644
--- a/drivers/iio/accel/adxl355_core.c
+++ b/drivers/iio/accel/adxl355_core.c
@@ -351,7 +351,7 @@ static int adxl355_setup(struct adxl355_data *data)
return ret;
/* Wait at least 5ms after software reset */
- usleep_range(5000, 10000);
+ fsleep(5000);
/* Read shadow registers for comparison */
ret = regmap_bulk_read(data->regmap,
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] iio: accel: adxl355: replace usleep_range() with fsleep()
2026-05-10 5:08 [PATCH] iio: accel: adxl355: replace usleep_range() with fsleep() Stepan Ionichev
@ 2026-05-10 5:53 ` Stepan Ionichev
2026-05-10 18:09 ` Andy Shevchenko
2026-05-10 12:54 ` [PATCH] " Andy Shevchenko
1 sibling, 1 reply; 4+ messages in thread
From: Stepan Ionichev @ 2026-05-10 5:53 UTC (permalink / raw)
To: jic23
Cc: lars, Michael.Hennerich, puranjay, dlechner, nuno.sa, andy,
linux-iio, linux-kernel, sozdayvek
The "at least 5ms" wait after software reset has no specific upper
bound. Use fsleep() with 5 * USEC_PER_MSEC to make the unit
explicit at the call site.
No functional change.
Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
---
drivers/iio/accel/adxl355_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_core.c
index 8f90c58f4..9d4421653 100644
--- a/drivers/iio/accel/adxl355_core.c
+++ b/drivers/iio/accel/adxl355_core.c
@@ -351,7 +351,7 @@ static int adxl355_setup(struct adxl355_data *data)
return ret;
/* Wait at least 5ms after software reset */
- usleep_range(5000, 10000);
+ fsleep(5 * USEC_PER_MSEC);
/* Read shadow registers for comparison */
ret = regmap_bulk_read(data->regmap,
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: accel: adxl355: replace usleep_range() with fsleep()
2026-05-10 5:08 [PATCH] iio: accel: adxl355: replace usleep_range() with fsleep() Stepan Ionichev
2026-05-10 5:53 ` [PATCH v2] " Stepan Ionichev
@ 2026-05-10 12:54 ` Andy Shevchenko
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2026-05-10 12:54 UTC (permalink / raw)
To: Stepan Ionichev
Cc: jic23, lars, Michael.Hennerich, puranjay, dlechner, nuno.sa, andy,
linux-iio, linux-kernel
On Sun, May 10, 2026 at 10:08:20AM +0500, Stepan Ionichev wrote:
> The "at least 5ms" wait after software reset has no specific upper
> bound. Switch to fsleep() which is the kernel helper for plain
> "about N microseconds" delays.
>
> No functional change.
...
> /* Wait at least 5ms after software reset */
> - usleep_range(5000, 10000);
> + fsleep(5000);
Even better to use predefined multiplier:
fsleep(5 * USEC_PER_MSEC);
This gives a hint on the value units without even needing / reading
the comment.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] iio: accel: adxl355: replace usleep_range() with fsleep()
2026-05-10 5:53 ` [PATCH v2] " Stepan Ionichev
@ 2026-05-10 18:09 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2026-05-10 18:09 UTC (permalink / raw)
To: Stepan Ionichev
Cc: jic23, lars, Michael.Hennerich, puranjay, dlechner, nuno.sa, andy,
linux-iio, linux-kernel
On Sun, May 10, 2026 at 10:53:03AM +0500, Stepan Ionichev wrote:
> The "at least 5ms" wait after software reset has no specific upper
> bound. Use fsleep() with 5 * USEC_PER_MSEC to make the unit
> explicit at the call site.
>
> No functional change.
>
> Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
> ---
You missed a changelog here.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-10 18:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-10 5:08 [PATCH] iio: accel: adxl355: replace usleep_range() with fsleep() Stepan Ionichev
2026-05-10 5:53 ` [PATCH v2] " Stepan Ionichev
2026-05-10 18:09 ` Andy Shevchenko
2026-05-10 12:54 ` [PATCH] " Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox