From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Joshua Crofts" <joshua.crofts1@gmail.com>,
"Nuno Sá" <noname.nuno@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] iio: magnetometer: ak8975: switch to using managed resources
Date: Tue, 12 May 2026 12:15:23 +0100 [thread overview]
Message-ID: <20260512121523.0e3f4911@jic23-huawei> (raw)
In-Reply-To: <agLjiS9xv9HyzX8K@ashevche-desk.local>
On Tue, 12 May 2026 11:23:37 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Tue, May 12, 2026 at 10:12:35AM +0200, Joshua Crofts wrote:
> > On Tue, 12 May 2026 at 10:06, Nuno Sá <noname.nuno@gmail.com> wrote:
> > > > This is to prevent a resource leak. If we register the power_off
> > > > function at the end,
> > > > any potential probe() failures will leave the regulators on.
> > >
> > > Okay it does make sense! I now see the action is registered after
> > > ak8975_power_on() which what makes sense. Still would like to avoid that
> > > weird pm_runtime_set_active() call. It would be nice if we could
> > > guarantee through PM that the device get's suspended on unbind. Oh well,
> > > I guess this is ok.
> >
> > FYI, there is a new version where I addressed some of your comments.
>
> Btw, can we rearrange the patches that the most controversial one(s?) will go
> at the end (as much as possible) of the new series? Then we can work on it with
> a less burden and unneeded dragging of the 'good' patches. Jonathan, what do
> you think?
>
Definitely. I'm swamped (or as it's otherwise known neglecting the other
stuff I supposedly maintain). So anything that allows me to pick up partial
sets would be most welcome.
Jonathan
next prev parent reply other threads:[~2026-05-12 11:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 14:35 [PATCH 0/8] iio: magnetometer: ak8975: driver cleanup Joshua Crofts via B4 Relay
2026-05-07 14:35 ` [PATCH 1/8] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Joshua Crofts via B4 Relay
2026-05-09 8:48 ` Nuno Sá
2026-05-07 14:35 ` [PATCH 2/8] iio: magnetometer: ak8975: check if gpiod read was successful Joshua Crofts via B4 Relay
2026-05-09 8:49 ` Nuno Sá
2026-05-07 14:35 ` [PATCH 3/8] iio: magnetometer: ak8975: switch to using managed resources Joshua Crofts via B4 Relay
2026-05-08 9:58 ` Andy Shevchenko
2026-05-08 13:51 ` Joshua Crofts
2026-05-09 6:52 ` Andy Shevchenko
2026-05-09 7:47 ` Joshua Crofts
2026-05-09 7:54 ` Andy Shevchenko
2026-05-11 18:17 ` Jonathan Cameron
2026-05-09 9:03 ` Nuno Sá
2026-05-09 13:32 ` Joshua Crofts
2026-05-12 8:07 ` Nuno Sá
2026-05-12 8:12 ` Joshua Crofts
2026-05-12 8:23 ` Andy Shevchenko
2026-05-12 11:15 ` Jonathan Cameron [this message]
2026-05-09 17:15 ` Andy Shevchenko
2026-05-11 7:04 ` Joshua Crofts
2026-05-11 13:12 ` Jonathan Cameron
2026-05-07 14:35 ` [PATCH 4/8] iio: magnetometer: ak8975: consistently use 'data' parameter Joshua Crofts via B4 Relay
2026-05-09 9:04 ` Nuno Sá
2026-05-07 14:35 ` [PATCH 5/8] iio: magnetometer: ak8975: unify messages with help of dev_err_probe() Joshua Crofts via B4 Relay
2026-05-09 9:05 ` Nuno Sá
2026-05-07 14:35 ` [PATCH 6/8] iio: magnetometer: ak8975: use temporary variable for struct device Joshua Crofts via B4 Relay
2026-05-09 9:06 ` Nuno Sá
2026-05-07 14:35 ` [PATCH 7/8] iio: magnetometer: ak8975: add scan mask index enum Joshua Crofts via B4 Relay
2026-05-09 9:07 ` Nuno Sá
2026-05-07 14:35 ` [PATCH 8/8] iio: magnetometer: ak8975: make use of the macros from bits.h Joshua Crofts via B4 Relay
2026-05-09 9:09 ` Nuno Sá
2026-05-09 9:15 ` Joshua Crofts
2026-05-09 17:16 ` Andy Shevchenko
2026-05-08 7:39 ` [PATCH 0/8] iio: magnetometer: ak8975: driver cleanup Andy Shevchenko
2026-05-08 8:59 ` Joshua Crofts
2026-05-08 9:19 ` Andy Shevchenko
2026-05-08 13:34 ` Jonathan Cameron
2026-05-08 13:45 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512121523.0e3f4911@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox