From: Adi Nata <adinata.softwareengineer@gmail.com>
To: joshua.crofts1@gmail.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
u.kleine-koenig@baylibre.com, email@sirat.me,
bhelgaas@google.com, mazziesaccount@gmail.com,
adinata.softwareengineer@gmail.com,
krzysztof.kozlowski@oss.qualcomm.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: linux-kernel-mentees@lists.linux.dev
Subject: [PATCH v2] iio: chemical: sgp30: fix checkpatch warn to prefer __packed
Date: Sun, 2 Aug 2026 10:51:31 +0800 [thread overview]
Message-ID: <20260802025134.25319-1-adinata.softwareengineer@gmail.com> (raw)
In-Reply-To: <20260723235542.152a6a25@systembl0wer>
Change instance of __attribute__((__packed__)) to __packed per checkpatch.pl warning
Reported by checkpatch:
FILE: drivers/iio/chemical/sgp30.c
WARNING: Prefer __packed over __attribute__((__packed__))
+} __attribute__((__packed__));
Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
v2:
- Rename commit title and message
---
drivers/iio/chemical/sgp30.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c
index f10bbebc29e4..c33592a1e0c9 100644
--- a/drivers/iio/chemical/sgp30.c
+++ b/drivers/iio/chemical/sgp30.c
@@ -82,7 +82,7 @@ struct sgp_version {
struct sgp_crc_word {
__be16 value;
u8 crc8;
-} __attribute__((__packed__));
+} __packed;
union sgp_reading {
u8 start;
--
2.47.3
next prev parent reply other threads:[~2026-08-02 2:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 16:18 [PATCH] [PATCH] iio: chemical: sgp30: cleanup codestyle warning Adi Nata
2026-07-23 21:55 ` Joshua Crofts
2026-08-02 2:51 ` Adi Nata [this message]
2026-08-02 12:34 ` [PATCH v2] iio: chemical: sgp30: fix checkpatch warn to prefer __packed Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260802025134.25319-1-adinata.softwareengineer@gmail.com \
--to=adinata.softwareengineer@gmail.com \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox