* [PATCH] [PATCH] iio: chemical: sgp30: cleanup codestyle warning
@ 2026-07-23 16:18 Adi Nata
2026-07-23 21:55 ` Joshua Crofts
0 siblings, 1 reply; 3+ messages in thread
From: Adi Nata @ 2026-07-23 16:18 UTC (permalink / raw)
To: jic23, dlechner, nuno.sa, andy, u.kleine-koenig, email,
krzysztof.kozlowski, mazziesaccount, adinata.softwareengineer,
linux-iio, linux-kernel
Cc: linux-kernel-mentees
Reported by checkpatch:
FILE: drivers/iio/chemical/sgp30.c
WARNING: Prefer __packed over __attribute__((__packed__))
+} __attribute__((__packed__));
Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
---
drivers/iio/chemical/sgp30.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c
index f10bbebc29e4..c33592a1e0c9 100644
--- a/drivers/iio/chemical/sgp30.c
+++ b/drivers/iio/chemical/sgp30.c
@@ -82,7 +82,7 @@ struct sgp_version {
struct sgp_crc_word {
__be16 value;
u8 crc8;
-} __attribute__((__packed__));
+} __packed;
union sgp_reading {
u8 start;
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [PATCH] iio: chemical: sgp30: cleanup codestyle warning
2026-07-23 16:18 [PATCH] [PATCH] iio: chemical: sgp30: cleanup codestyle warning Adi Nata
@ 2026-07-23 21:55 ` Joshua Crofts
2026-08-02 2:51 ` [PATCH v2] iio: chemical: sgp30: fix checkpatch warn to prefer __packed Adi Nata
0 siblings, 1 reply; 3+ messages in thread
From: Joshua Crofts @ 2026-07-23 21:55 UTC (permalink / raw)
To: Adi Nata
Cc: jic23, dlechner, nuno.sa, andy, u.kleine-koenig, email,
krzysztof.kozlowski, mazziesaccount, linux-iio, linux-kernel,
linux-kernel-mentees
On Fri, 24 Jul 2026 00:18:49 +0800
Adi Nata <adinata.softwareengineer@gmail.com> wrote:
> Reported by checkpatch:
> FILE: drivers/iio/chemical/sgp30.c
> WARNING: Prefer __packed over __attribute__((__packed__))
> +} __attribute__((__packed__));
>
> Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
> ---
Same issues as with your previous patch. Additionally, the
subject contains two [PATCH] tags, perhaps you've used git
format-patch or git send-email incorrectly?
After fixing:
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] iio: chemical: sgp30: fix checkpatch warn to prefer __packed
2026-07-23 21:55 ` Joshua Crofts
@ 2026-08-02 2:51 ` Adi Nata
0 siblings, 0 replies; 3+ messages in thread
From: Adi Nata @ 2026-08-02 2:51 UTC (permalink / raw)
To: joshua.crofts1, jic23, dlechner, nuno.sa, andy, u.kleine-koenig,
email, bhelgaas, mazziesaccount, adinata.softwareengineer,
krzysztof.kozlowski, linux-iio, linux-kernel
Cc: linux-kernel-mentees
Change instance of __attribute__((__packed__)) to __packed per checkpatch.pl warning
Reported by checkpatch:
FILE: drivers/iio/chemical/sgp30.c
WARNING: Prefer __packed over __attribute__((__packed__))
+} __attribute__((__packed__));
Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
v2:
- Rename commit title and message
---
drivers/iio/chemical/sgp30.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c
index f10bbebc29e4..c33592a1e0c9 100644
--- a/drivers/iio/chemical/sgp30.c
+++ b/drivers/iio/chemical/sgp30.c
@@ -82,7 +82,7 @@ struct sgp_version {
struct sgp_crc_word {
__be16 value;
u8 crc8;
-} __attribute__((__packed__));
+} __packed;
union sgp_reading {
u8 start;
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-02 2:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 16:18 [PATCH] [PATCH] iio: chemical: sgp30: cleanup codestyle warning Adi Nata
2026-07-23 21:55 ` Joshua Crofts
2026-08-02 2:51 ` [PATCH v2] iio: chemical: sgp30: fix checkpatch warn to prefer __packed Adi Nata
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox