* [PATCH v2] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
@ 2026-09-09 13:03 Joshua Crofts
2026-09-09 13:38 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Joshua Crofts @ 2026-09-09 13:03 UTC (permalink / raw)
To: Kim Seer Paller, Marilene Andrade Garcia, Jonathan Cameron,
David Lechner, Nuno Sá, Andy Shevchenko
Cc: linux-iio, linux-kernel, stable
The MAX14001 has an SPI ID table, but does not export it with the
MODULE_DEVICE_TABLE(spi, ...) macro. Because of this, SPI-based module
autoloading fails on systems that don't use devicetree (e.g. via
spi_board_info).
Add the missing macro to export the alias information.
Fixes: 59795109fa67 ("iio: adc: max14001: New driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
drivers/iio/adc/max14001.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/max14001.c b/drivers/iio/adc/max14001.c
index 58adeac62dde..7694fbb6a9fd 100644
--- a/drivers/iio/adc/max14001.c
+++ b/drivers/iio/adc/max14001.c
@@ -366,6 +366,7 @@ static const struct spi_device_id max14001_id_table[] = {
{ .name = "max14002", .driver_data = (kernel_ulong_t)&max14002_chip_info },
{ }
};
+MODULE_DEVICE_TABLE(spi, max14001_id_table);
static const struct of_device_id max14001_of_match[] = {
{ .compatible = "adi,max14001", .data = &max14001_chip_info },
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
2026-09-09 13:03 [PATCH v2] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro Joshua Crofts
@ 2026-09-09 13:38 ` Andy Shevchenko
2026-09-09 13:45 ` Joshua Crofts
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-09-09 13:38 UTC (permalink / raw)
To: Joshua Crofts
Cc: Kim Seer Paller, Marilene Andrade Garcia, Jonathan Cameron,
David Lechner, Nuno Sá, Andy Shevchenko, linux-iio,
linux-kernel, stable
On Wed, Sep 09, 2026 at 01:03:04PM +0000, Joshua Crofts wrote:
> The MAX14001 has an SPI ID table, but does not export it with the
> MODULE_DEVICE_TABLE(spi, ...) macro. Because of this, SPI-based module
> autoloading fails on systems that don't use devicetree (e.g. via
> spi_board_info).
>
> Add the missing macro to export the alias information.
>
> Fixes: 59795109fa67 ("iio: adc: max14001: New driver")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---
Changelog?
> drivers/iio/adc/max14001.c | 1 +
> 1 file changed, 1 insertion(+)
Code wise LGTM.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
2026-09-09 13:38 ` Andy Shevchenko
@ 2026-09-09 13:45 ` Joshua Crofts
2026-09-09 14:05 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Joshua Crofts @ 2026-09-09 13:45 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Kim Seer Paller, Marilene Andrade Garcia, Jonathan Cameron,
David Lechner, Nuno Sá, Andy Shevchenko, linux-iio,
linux-kernel, stable
On Wed, 9 Sep 2026 16:38:50 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Sep 09, 2026 at 01:03:04PM +0000, Joshua Crofts wrote:
> > The MAX14001 has an SPI ID table, but does not export it with the
> > MODULE_DEVICE_TABLE(spi, ...) macro. Because of this, SPI-based module
> > autoloading fails on systems that don't use devicetree (e.g. via
> > spi_board_info).
> >
> > Add the missing macro to export the alias information.
> >
> > Fixes: 59795109fa67 ("iio: adc: max14001: New driver")
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> > ---
>
> Changelog?
God, I should start using AI to check my patches before sending.
Appending below.
Changes in v2:
- edit commit message (expand on module autoloading and SPI)
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
2026-09-09 13:45 ` Joshua Crofts
@ 2026-09-09 14:05 ` Andy Shevchenko
2026-09-13 21:57 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-09-09 14:05 UTC (permalink / raw)
To: Joshua Crofts
Cc: Kim Seer Paller, Marilene Andrade Garcia, Jonathan Cameron,
David Lechner, Nuno Sá, Andy Shevchenko, linux-iio,
linux-kernel, stable
On Wed, Sep 09, 2026 at 03:45:26PM +0200, Joshua Crofts wrote:
> On Wed, 9 Sep 2026 16:38:50 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
>
> > On Wed, Sep 09, 2026 at 01:03:04PM +0000, Joshua Crofts wrote:
> > > The MAX14001 has an SPI ID table, but does not export it with the
> > > MODULE_DEVICE_TABLE(spi, ...) macro. Because of this, SPI-based module
> > > autoloading fails on systems that don't use devicetree (e.g. via
> > > spi_board_info).
> > >
> > > Add the missing macro to export the alias information.
> > >
> > > Fixes: 59795109fa67 ("iio: adc: max14001: New driver")
> > > Cc: <stable@vger.kernel.org>
> > > Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> > > ---
> >
> > Changelog?
>
> God, I should start using AI to check my patches before sending.
> Appending below.
>
> Changes in v2:
> - edit commit message (expand on module autoloading and SPI)
Thanks.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
2026-09-09 14:05 ` Andy Shevchenko
@ 2026-09-13 21:57 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2026-09-13 21:57 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Joshua Crofts, Kim Seer Paller, Marilene Andrade Garcia,
David Lechner, Nuno Sá, Andy Shevchenko, linux-iio,
linux-kernel, stable
On Wed, 9 Sep 2026 17:05:50 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Sep 09, 2026 at 03:45:26PM +0200, Joshua Crofts wrote:
> > On Wed, 9 Sep 2026 16:38:50 +0300
> > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> >
> > > On Wed, Sep 09, 2026 at 01:03:04PM +0000, Joshua Crofts wrote:
> > > > The MAX14001 has an SPI ID table, but does not export it with the
> > > > MODULE_DEVICE_TABLE(spi, ...) macro. Because of this, SPI-based module
> > > > autoloading fails on systems that don't use devicetree (e.g. via
> > > > spi_board_info).
> > > >
> > > > Add the missing macro to export the alias information.
> > > >
> > > > Fixes: 59795109fa67 ("iio: adc: max14001: New driver")
> > > > Cc: <stable@vger.kernel.org>
> > > > Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> > > > ---
> > >
> > > Changelog?
> >
> > God, I should start using AI to check my patches before sending.
> > Appending below.
> >
> > Changes in v2:
> > - edit commit message (expand on module autoloading and SPI)
>
> Thanks.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Applied to the testing branch of iio.git. Not rushing this
in as for dt at least the other MODULE_DEVICE Table probably
does the job (or the driver name fallback).
So nice to have rather than urgent
thanks,
Jonathan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-09-13 21:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-09 13:03 [PATCH v2] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro Joshua Crofts
2026-09-09 13:38 ` Andy Shevchenko
2026-09-09 13:45 ` Joshua Crofts
2026-09-09 14:05 ` Andy Shevchenko
2026-09-13 21:57 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox