Linux IIO development
 help / color / mirror / Atom feed
* [PATCH v5] dt-bindings: iio: adc: lltc,ltc2497: generalise the title
@ 2026-09-15 14:46 Andrei Stancovici
  2026-09-17  3:26 ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Andrei Stancovici @ 2026-09-15 14:46 UTC (permalink / raw)
  To: Nuno Sá, Michael Hennerich, Jonathan Cameron, David Lechner,
	Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Liam Beguin, linux, linux-iio, devicetree, linux-kernel
  Cc: Andrei Stancovici

The title names two of the four parts the schema documents: the LTC2305
and the LTC2499 are in the compatible enum and in the description, but
not in the title. Rather than extend the list each time a part is added,
say "LTC2497 and similar ADCs", as bindings covering a large number of
parts tend to end up doing. The full list stays in the description.

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Andrei Stancovici <andrei.stancovici@analog.com>
---
Changes in v5:
- Only this patch is resent. Patches 2 and 3 of the v4 series ("add
  LTC2499 internal temperature channel" and "add 2x conversion speed
  mode") are already on the testing branch of iio.git, so v5 is a
  single-patch round.
- The title is now generalised instead of enumerating one more part.
  v4 added the LTC2499 to it; Sashiko then pointed out that the LTC2305
  is also supported and also missing, and Jonathan suggested stopping
  the enumeration and using "LTC2497 and similar" as bindings with many
  supported parts tend to do. The full list is already in the
  description and is left alone.
- Documentation only; no driver change, so no hardware run for this
  patch. The DC1012A-A validation previously reported covers the applied
  patches 2 and 3.

v4: https://lore.kernel.org/r/20260909082755.366269-1-andrei.stancovici@analog.com

 Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
index c884b6e03767..67445ad2bb3b 100644
--- a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
@@ -4,7 +4,7 @@
 $id: http://devicetree.org/schemas/iio/adc/lltc,ltc2497.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Linear Technology / Analog Devices LTC2497 and LTC2309 ADC
+title: Linear Technology / Analog Devices LTC2497 and similar ADCs
 
 maintainers:
   - Michael Hennerich <michael.hennerich@analog.com>

base-commit: 36c12dbda81c284d72f3c64689461647497b643b
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v5] dt-bindings: iio: adc: lltc,ltc2497: generalise the title
  2026-09-15 14:46 [PATCH v5] dt-bindings: iio: adc: lltc,ltc2497: generalise the title Andrei Stancovici
@ 2026-09-17  3:26 ` Jonathan Cameron
  2026-09-21  3:22   ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2026-09-17  3:26 UTC (permalink / raw)
  To: Andrei Stancovici
  Cc: Nuno Sá, Michael Hennerich, David Lechner, Andy Shevchenko,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Liam Beguin,
	linux, linux-iio, devicetree, linux-kernel

On Tue, 15 Sep 2026 17:46:24 +0300
Andrei Stancovici <andrei.stancovici@analog.com> wrote:

> The title names two of the four parts the schema documents: the LTC2305
> and the LTC2499 are in the compatible enum and in the description, but
> not in the title. Rather than extend the list each time a part is added,
> say "LTC2497 and similar ADCs", as bindings covering a large number of
> parts tend to end up doing. The full list stays in the description.
> 
> Acked-by: Rob Herring (Arm) <robh@kernel.org>

This is one where carrying the ack is not valid (unless I missed
Rob saying he was fine with it). The whole patch was about the title
which is now different!  Given the dt maintainers have automation
around this I'm not sure anyone will take another look. Leave
it a few days then send a v6 with Rob's Ack dropped.

Thanks,

Jonathan

> Signed-off-by: Andrei Stancovici <andrei.stancovici@analog.com>
> ---
> Changes in v5:
> - Only this patch is resent. Patches 2 and 3 of the v4 series ("add
>   LTC2499 internal temperature channel" and "add 2x conversion speed
>   mode") are already on the testing branch of iio.git, so v5 is a
>   single-patch round.
> - The title is now generalised instead of enumerating one more part.
>   v4 added the LTC2499 to it; Sashiko then pointed out that the LTC2305
>   is also supported and also missing, and Jonathan suggested stopping
>   the enumeration and using "LTC2497 and similar" as bindings with many
>   supported parts tend to do. The full list is already in the
>   description and is left alone.
> - Documentation only; no driver change, so no hardware run for this
>   patch. The DC1012A-A validation previously reported covers the applied
>   patches 2 and 3.
> 
> v4: https://lore.kernel.org/r/20260909082755.366269-1-andrei.stancovici@analog.com
> 
>  Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> index c884b6e03767..67445ad2bb3b 100644
> --- a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/iio/adc/lltc,ltc2497.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Linear Technology / Analog Devices LTC2497 and LTC2309 ADC
> +title: Linear Technology / Analog Devices LTC2497 and similar ADCs
>  
>  maintainers:
>    - Michael Hennerich <michael.hennerich@analog.com>
> 
> base-commit: 36c12dbda81c284d72f3c64689461647497b643b


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v5] dt-bindings: iio: adc: lltc,ltc2497: generalise the title
  2026-09-17  3:26 ` Jonathan Cameron
@ 2026-09-21  3:22   ` Jonathan Cameron
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2026-09-21  3:22 UTC (permalink / raw)
  To: Andrei Stancovici
  Cc: Nuno Sá, Michael Hennerich, David Lechner, Andy Shevchenko,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Liam Beguin,
	linux, linux-iio, devicetree, linux-kernel

On Thu, 17 Sep 2026 04:26:12 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Tue, 15 Sep 2026 17:46:24 +0300
> Andrei Stancovici <andrei.stancovici@analog.com> wrote:
> 
> > The title names two of the four parts the schema documents: the LTC2305
> > and the LTC2499 are in the compatible enum and in the description, but
> > not in the title. Rather than extend the list each time a part is added,
> > say "LTC2497 and similar ADCs", as bindings covering a large number of
> > parts tend to end up doing. The full list stays in the description.
> > 
> > Acked-by: Rob Herring (Arm) <robh@kernel.org>  
> 
> This is one where carrying the ack is not valid (unless I missed
> Rob saying he was fine with it). The whole patch was about the title
> which is now different!  Given the dt maintainers have automation
> around this I'm not sure anyone will take another look. Leave
> it a few days then send a v6 with Rob's Ack dropped.

Not worth poking Rob over, so I've dropped his tag and applied.
Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> > Signed-off-by: Andrei Stancovici <andrei.stancovici@analog.com>
> > ---
> > Changes in v5:
> > - Only this patch is resent. Patches 2 and 3 of the v4 series ("add
> >   LTC2499 internal temperature channel" and "add 2x conversion speed
> >   mode") are already on the testing branch of iio.git, so v5 is a
> >   single-patch round.
> > - The title is now generalised instead of enumerating one more part.
> >   v4 added the LTC2499 to it; Sashiko then pointed out that the LTC2305
> >   is also supported and also missing, and Jonathan suggested stopping
> >   the enumeration and using "LTC2497 and similar" as bindings with many
> >   supported parts tend to do. The full list is already in the
> >   description and is left alone.
> > - Documentation only; no driver change, so no hardware run for this
> >   patch. The DC1012A-A validation previously reported covers the applied
> >   patches 2 and 3.
> > 
> > v4: https://lore.kernel.org/r/20260909082755.366269-1-andrei.stancovici@analog.com
> > 
> >  Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> > index c884b6e03767..67445ad2bb3b 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> > @@ -4,7 +4,7 @@
> >  $id: http://devicetree.org/schemas/iio/adc/lltc,ltc2497.yaml#
> >  $schema: http://devicetree.org/meta-schemas/core.yaml#
> >  
> > -title: Linear Technology / Analog Devices LTC2497 and LTC2309 ADC
> > +title: Linear Technology / Analog Devices LTC2497 and similar ADCs
> >  
> >  maintainers:
> >    - Michael Hennerich <michael.hennerich@analog.com>
> > 
> > base-commit: 36c12dbda81c284d72f3c64689461647497b643b  
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-21  3:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-15 14:46 [PATCH v5] dt-bindings: iio: adc: lltc,ltc2497: generalise the title Andrei Stancovici
2026-09-17  3:26 ` Jonathan Cameron
2026-09-21  3:22   ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox