From: Jonathan Cameron <jic23@cam.ac.uk>
To: Barry Song <21cnbao@gmail.com>
Cc: gregkh@suse.de, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/3] adis16400: fix some minor issues and clean-up
Date: Fri, 04 Jun 2010 11:58:14 +0100 [thread overview]
Message-ID: <4C08DC46.8010907@cam.ac.uk> (raw)
In-Reply-To: <1275643194-25328-3-git-send-email-21cnbao@gmail.com>
On 06/04/10 10:19, Barry Song wrote:
> 1. move adis16400_spi_read_burst() to adis16400_ring.c since it is only
> called there
> 2. add the lost calling to adis16400_self_test()
> 3. codes cleanup
>
Same issue with commit comment location
> Signed-off-by: Barry Song <21cnbao@gmail.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> drivers/staging/iio/imu/adis16400.h | 6 --
> drivers/staging/iio/imu/adis16400_core.c | 84 +++++++----------------------
> drivers/staging/iio/imu/adis16400_ring.c | 48 +++++++++++++++++
> 3 files changed, 70 insertions(+), 71 deletions(-)
...
next prev parent reply other threads:[~2010-06-04 10:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 9:19 [PATCH 0/3] adis16xxx: fix some minor issues and clean-up Barry Song
2010-06-04 9:19 ` [PATCH 1/3] adis16300: " Barry Song
2010-06-04 9:19 ` [PATCH 2/3] adis16400: " Barry Song
2010-06-04 9:19 ` [PATCH 3/3] adis16209/220/240/350: tuning spi delay to make hardware more stable Barry Song
2010-06-04 10:59 ` Jonathan Cameron
2010-06-04 10:58 ` Jonathan Cameron [this message]
2010-06-04 15:28 ` [PATCH 2/3] adis16400: fix some minor issues and clean-up Greg KH
2010-06-04 15:39 ` Jonathan Cameron
2010-06-04 10:56 ` [PATCH 1/3] adis16300: " Jonathan Cameron
2010-06-04 15:28 ` Greg KH
2010-06-05 0:43 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C08DC46.8010907@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=21cnbao@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox