From: Jonathan Cameron <jic23@cam.ac.uk>
To: Barry Song <21cnbao@gmail.com>
Cc: gregkh@suse.de, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/3] adis16209/220/240/350: tuning spi delay to make hardware more stable
Date: Fri, 04 Jun 2010 11:59:31 +0100 [thread overview]
Message-ID: <4C08DC93.7080005@cam.ac.uk> (raw)
In-Reply-To: <1275643194-25328-4-git-send-email-21cnbao@gmail.com>
This clearly also fixes an incorrect message. Obviously that is trivial
but it isn't apparent in commit message or comments.
> Signed-off-by: Barry Song <21cnbao@gmail.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> drivers/staging/iio/accel/adis16209_core.c | 6 ++++--
> drivers/staging/iio/accel/adis16220_core.c | 12 ++++++------
> drivers/staging/iio/accel/adis16240_core.c | 8 ++++----
> drivers/staging/iio/imu/adis16350_core.c | 8 ++++----
> 4 files changed, 19 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209_core.c b/drivers/staging/iio/accel/adis16209_core.c
> index ac375c5..94491a1 100644
> --- a/drivers/staging/iio/accel/adis16209_core.c
> +++ b/drivers/staging/iio/accel/adis16209_core.c
> @@ -76,11 +76,13 @@ static int adis16209_spi_write_reg_16(struct device *dev,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> + .delay_usecs = 30,
> }, {
> .tx_buf = st->tx + 2,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> + .delay_usecs = 30,
> },
> };
>
> @@ -120,13 +122,13 @@ static int adis16209_spi_read_reg_16(struct device *dev,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 20,
> + .delay_usecs = 30,
> }, {
> .rx_buf = st->rx,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 20,
> + .delay_usecs = 30,
> },
> };
>
> diff --git a/drivers/staging/iio/accel/adis16220_core.c b/drivers/staging/iio/accel/adis16220_core.c
> index 6de439f..fffa49c 100644
> --- a/drivers/staging/iio/accel/adis16220_core.c
> +++ b/drivers/staging/iio/accel/adis16220_core.c
> @@ -72,13 +72,13 @@ static int adis16220_spi_write_reg_16(struct device *dev,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> }, {
> .tx_buf = st->tx + 2,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> },
> };
>
> @@ -118,13 +118,13 @@ static int adis16220_spi_read_reg_16(struct device *dev,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> }, {
> .rx_buf = st->rx,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> },
> };
>
> @@ -291,9 +291,9 @@ static int adis16220_check_status(struct device *dev)
> if (status & ADIS16220_DIAG_STAT_FLASH_UPT)
> dev_err(dev, "Flash update failed\n");
> if (status & ADIS16220_DIAG_STAT_POWER_HIGH)
> - dev_err(dev, "Power supply above 5.25V\n");
> + dev_err(dev, "Power supply above 3.625V\n");
> if (status & ADIS16220_DIAG_STAT_POWER_LOW)
> - dev_err(dev, "Power supply below 4.75V\n");
> + dev_err(dev, "Power supply below 3.15V\n");
>
> error_ret:
> return ret;
> diff --git a/drivers/staging/iio/accel/adis16240_core.c b/drivers/staging/iio/accel/adis16240_core.c
> index 54fd6d7..731bca6 100644
> --- a/drivers/staging/iio/accel/adis16240_core.c
> +++ b/drivers/staging/iio/accel/adis16240_core.c
> @@ -74,13 +74,13 @@ static int adis16240_spi_write_reg_16(struct device *dev,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> }, {
> .tx_buf = st->tx + 2,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> },
> };
>
> @@ -120,13 +120,13 @@ static int adis16240_spi_read_reg_16(struct device *dev,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> }, {
> .rx_buf = st->rx,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> },
> };
>
> diff --git a/drivers/staging/iio/imu/adis16350_core.c b/drivers/staging/iio/imu/adis16350_core.c
> index 0edde73..0bb19a9 100644
> --- a/drivers/staging/iio/imu/adis16350_core.c
> +++ b/drivers/staging/iio/imu/adis16350_core.c
> @@ -75,13 +75,13 @@ static int adis16350_spi_write_reg_16(struct device *dev,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> }, {
> .tx_buf = st->tx + 2,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> },
> };
>
> @@ -121,13 +121,13 @@ static int adis16350_spi_read_reg_16(struct device *dev,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> }, {
> .rx_buf = st->rx,
> .bits_per_word = 8,
> .len = 2,
> .cs_change = 1,
> - .delay_usecs = 25,
> + .delay_usecs = 35,
> },
> };
>
next prev parent reply other threads:[~2010-06-04 10:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 9:19 [PATCH 0/3] adis16xxx: fix some minor issues and clean-up Barry Song
2010-06-04 9:19 ` [PATCH 1/3] adis16300: " Barry Song
2010-06-04 9:19 ` [PATCH 2/3] adis16400: " Barry Song
2010-06-04 9:19 ` [PATCH 3/3] adis16209/220/240/350: tuning spi delay to make hardware more stable Barry Song
2010-06-04 10:59 ` Jonathan Cameron [this message]
2010-06-04 10:58 ` [PATCH 2/3] adis16400: fix some minor issues and clean-up Jonathan Cameron
2010-06-04 15:28 ` Greg KH
2010-06-04 15:39 ` Jonathan Cameron
2010-06-04 10:56 ` [PATCH 1/3] adis16300: " Jonathan Cameron
2010-06-04 15:28 ` Greg KH
2010-06-05 0:43 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C08DC93.7080005@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=21cnbao@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox