From: Jonathan Cameron <jic23@cam.ac.uk>
To: Greg KH <gregkh@suse.de>
Cc: Barry Song <21cnbao@gmail.com>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/3] adis16400: fix some minor issues and clean-up
Date: Fri, 04 Jun 2010 16:39:59 +0100 [thread overview]
Message-ID: <4C091E4F.3090000@cam.ac.uk> (raw)
In-Reply-To: <20100604152832.GC25400@suse.de>
On 06/04/10 16:28, Greg KH wrote:
> On Fri, Jun 04, 2010 at 11:58:14AM +0100, Jonathan Cameron wrote:
>> On 06/04/10 10:19, Barry Song wrote:
>>> 1. move adis16400_spi_read_burst() to adis16400_ring.c since it is only
>>> called there
>>> 2. add the lost calling to adis16400_self_test()
>>> 3. codes cleanup
>>>
>> Same issue with commit comment location
>
> Same confusion on my part, what's wrong with this? This is what should
> be in the changelog, right?
Fair enough. I just thought the clean up etc was pretty much covered by the title
and the rest was merely clarification. I'll go with your opinion though as you have
been doing this a lot longer than I have!
Barry, sorry for the confusion!
Jonathan
next prev parent reply other threads:[~2010-06-04 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 9:19 [PATCH 0/3] adis16xxx: fix some minor issues and clean-up Barry Song
2010-06-04 9:19 ` [PATCH 1/3] adis16300: " Barry Song
2010-06-04 9:19 ` [PATCH 2/3] adis16400: " Barry Song
2010-06-04 9:19 ` [PATCH 3/3] adis16209/220/240/350: tuning spi delay to make hardware more stable Barry Song
2010-06-04 10:59 ` Jonathan Cameron
2010-06-04 10:58 ` [PATCH 2/3] adis16400: fix some minor issues and clean-up Jonathan Cameron
2010-06-04 15:28 ` Greg KH
2010-06-04 15:39 ` Jonathan Cameron [this message]
2010-06-04 10:56 ` [PATCH 1/3] adis16300: " Jonathan Cameron
2010-06-04 15:28 ` Greg KH
2010-06-05 0:43 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C091E4F.3090000@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=21cnbao@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox