* RFC: more consitent DAC sysfs attributes naming
@ 2010-11-19 8:33 Hennerich, Michael
2010-11-19 12:18 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Hennerich, Michael @ 2010-11-19 8:33 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
Hi Jonathan,
I wonder if it would make more sense to use this...
drivers/staging/iio/dac/dac.h | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/iio/dac/dac.h b/drivers/staging/iio/dac/dac.h
index 55005ee..62620ed 100644
--- a/drivers/staging/iio/dac/dac.h
+++ b/drivers/staging/iio/dac/dac.h
@@ -2,5 +2,9 @@
* dac.h - sysfs attributes associated with DACs
*/
+/* Deprecated */
#define IIO_DEV_ATTR_DAC(_num, _store, _addr) \
IIO_DEVICE_ATTR(dac_##_num, S_IWUSR, NULL, _store, _addr)
+
+#define IIO_DEV_ATTR_OUT_RAW(_num, _show, _addr) =
\
+ IIO_DEVICE_ATTR(out##_num##_raw, S_IWUSR, _show, NULL, _addr)
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036
Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: RFC: more consitent DAC sysfs attributes naming
2010-11-19 8:33 RFC: more consitent DAC sysfs attributes naming Hennerich, Michael
@ 2010-11-19 12:18 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2010-11-19 12:18 UTC (permalink / raw)
To: Hennerich, Michael
Cc: linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
On 11/19/10 08:33, Hennerich, Michael wrote:
> Hi Jonathan,
>
> I wonder if it would make more sense to use this...
>
> drivers/staging/iio/dac/dac.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/iio/dac/dac.h b/drivers/staging/iio/dac/dac.h
> index 55005ee..62620ed 100644
> --- a/drivers/staging/iio/dac/dac.h
> +++ b/drivers/staging/iio/dac/dac.h
> @@ -2,5 +2,9 @@
> * dac.h - sysfs attributes associated with DACs
> */
>
> +/* Deprecated */
> #define IIO_DEV_ATTR_DAC(_num, _store, _addr) \
> IIO_DEVICE_ATTR(dac_##_num, S_IWUSR, NULL, _store, _addr)
> +
> +#define IIO_DEV_ATTR_OUT_RAW(_num, _show, _addr) \
> + IIO_DEVICE_ATTR(out##_num##_raw, S_IWUSR, _show, NULL, _addr)
Yes, that seems like the logical equivalent to in0_raw to me.
>
>
> Greetings,
> Michael
>
> --
> Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
> Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036
> Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-19 12:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-19 8:33 RFC: more consitent DAC sysfs attributes naming Hennerich, Michael
2010-11-19 12:18 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox