[PATCHv2 0/2] iio: accel: kxcjk-1013: new ACPI id and

[PATCHv2 0/2] iio: accel: kxcjk-1013: new ACPI id and

[Antonio Ospite]

Hi,

compared to the v1 I fixed the typo (s/DSTD/DSDT/) in patch 1 and
dropped the renaming of is_smo8500_device.

Thanks,
   Antonio

Antonio Ospite (2):
  iio: accel: kxcjk-1013: add the "KXCJ9000" ACPI id
  iio: accel: kxcjk-1013: add some blank lines for readability

 drivers/iio/accel/kxcjk-1013.c | 4 ++++
 1 file changed, 4 insertions(+)

-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[PATCHv2 1/2] iio: accel: kxcjk-1013: add the "KXCJ9000" ACPI id

[Antonio Ospite]

This id has been seen in the DSDT of the Teclast X98 Air 3G tablet based
on Intel Bay Trail.

Signed-off-by: Antonio Ospite <ao2@ao2.it>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Bastien Nocera <hadess@hadess.net>
Cc: linux-iio@vger.kernel.org
---
 drivers/iio/accel/kxcjk-1013.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
index 51da369..5b7a860 100644
--- a/drivers/iio/accel/kxcjk-1013.c
+++ b/drivers/iio/accel/kxcjk-1013.c
@@ -1418,6 +1418,7 @@ static const struct dev_pm_ops kxcjk1013_pm_ops = {
 static const struct acpi_device_id kx_acpi_match[] = {
 	{"KXCJ1013", KXCJK1013},
 	{"KXCJ1008", KXCJ91008},
+	{"KXCJ9000", KXCJ91008},
 	{"KXTJ1009", KXTJ21009},
 	{"SMO8500",  KXCJ91008},
 	{ },
-- 
2.1.4

Re: [PATCHv2 1/2] iio: accel: kxcjk-1013: add the "KXCJ9000" ACPI id

[Jonathan Cameron]

On 04/05/15 10:13, Antonio Ospite wrote:
> This id has been seen in the DSDT of the Teclast X98 Air 3G tablet based
> on Intel Bay Trail.
> 
> Signed-off-by: Antonio Ospite <ao2@ao2.it>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Bastien Nocera <hadess@hadess.net>
> Cc: linux-iio@vger.kernel.org
Hmm.  I'm not entirely sure what he convention on this is.  It's not
a regression fix as this never worked, so not subject to a quick send
on for this merge cycle.  It is however a new ID which is acceptable
stable material.

Anyhow, the IIO convention from now on (unless someone points me at
a more general doc that suggests something else) is to take these
for the next merge window, but mark them for stable so they propagate
down to the long term stable kernels.

So applied to the togreg branch of iio.git - initially pushed out as
testing when I'm somewhere convenient with reliable internet access.

Jonathan
> ---
>  drivers/iio/accel/kxcjk-1013.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 51da369..5b7a860 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1418,6 +1418,7 @@ static const struct dev_pm_ops kxcjk1013_pm_ops = {
>  static const struct acpi_device_id kx_acpi_match[] = {
>  	{"KXCJ1013", KXCJK1013},
>  	{"KXCJ1008", KXCJ91008},
> +	{"KXCJ9000", KXCJ91008},
>  	{"KXTJ1009", KXTJ21009},
>  	{"SMO8500",  KXCJ91008},
>  	{ },
> 

Re: [PATCHv2 1/2] iio: accel: kxcjk-1013: add the "KXCJ9000" ACPI id

[Daniel Baluta]

On Mon, May 4, 2015 at 12:13 PM, Antonio Ospite <ao2@ao2.it> wrote:
> This id has been seen in the DSDT of the Teclast X98 Air 3G tablet based
> on Intel Bay Trail.
>
> Signed-off-by: Antonio Ospite <ao2@ao2.it>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Bastien Nocera <hadess@hadess.net>
> Cc: linux-iio@vger.kernel.org

Looks good to me.

Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>

> ---
>  drivers/iio/accel/kxcjk-1013.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 51da369..5b7a860 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1418,6 +1418,7 @@ static const struct dev_pm_ops kxcjk1013_pm_ops = {
>  static const struct acpi_device_id kx_acpi_match[] = {
>         {"KXCJ1013", KXCJK1013},
>         {"KXCJ1008", KXCJ91008},
> +       {"KXCJ9000", KXCJ91008},
>         {"KXTJ1009", KXTJ21009},
>         {"SMO8500",  KXCJ91008},
>         { },
> --
> 2.1.4
>

Re: [PATCHv2 1/2] iio: accel: kxcjk-1013: add the "KXCJ9000" ACPI id

[Jonathan Cameron]

On 04/05/15 11:50, Daniel Baluta wrote:
> On Mon, May 4, 2015 at 12:13 PM, Antonio Ospite <ao2@ao2.it> wrote:
>> This id has been seen in the DSDT of the Teclast X98 Air 3G tablet based
>> on Intel Bay Trail.
>>
>> Signed-off-by: Antonio Ospite <ao2@ao2.it>
>> Cc: Jonathan Cameron <jic23@kernel.org>
>> Cc: Bastien Nocera <hadess@hadess.net>
>> Cc: linux-iio@vger.kernel.org
> 
> Looks good to me.
> 
> Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
Added to the patch.
> 
>> ---
>>  drivers/iio/accel/kxcjk-1013.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
>> index 51da369..5b7a860 100644
>> --- a/drivers/iio/accel/kxcjk-1013.c
>> +++ b/drivers/iio/accel/kxcjk-1013.c
>> @@ -1418,6 +1418,7 @@ static const struct dev_pm_ops kxcjk1013_pm_ops = {
>>  static const struct acpi_device_id kx_acpi_match[] = {
>>         {"KXCJ1013", KXCJK1013},
>>         {"KXCJ1008", KXCJ91008},
>> +       {"KXCJ9000", KXCJ91008},
>>         {"KXTJ1009", KXTJ21009},
>>         {"SMO8500",  KXCJ91008},
>>         { },
>> --
>> 2.1.4
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[PATCHv2 2/2] iio: accel: kxcjk-1013: add some blank lines for readability

[Antonio Ospite]

Some extra blank lines between if checks don't hurt and improve
readability.

Signed-off-by: Antonio Ospite <ao2@ao2.it>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Bastien Nocera <hadess@hadess.net>
Cc: linux-iio@vger.kernel.org
---
 drivers/iio/accel/kxcjk-1013.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
index 5b7a860..937bfc2 100644
--- a/drivers/iio/accel/kxcjk-1013.c
+++ b/drivers/iio/accel/kxcjk-1013.c
@@ -1147,8 +1147,10 @@ static const char *kxcjk1013_match_acpi_device(struct device *dev,
 	id = acpi_match_device(dev->driver->acpi_match_table, dev);
 	if (!id)
 		return NULL;
+
 	if (strcmp(id->id, "SMO8500") == 0)
 		*is_smo8500_device = true;
+
 	*chipset = (enum kx_chipset)id->driver_data;
 
 	return dev_name(dev);
@@ -1163,6 +1165,7 @@ static int kxcjk1013_gpio_probe(struct i2c_client *client,
 
 	if (!client)
 		return -EINVAL;
+
 	if (data->is_smo8500_device)
 		return -ENOTSUPP;
 
-- 
2.1.4

Re: [PATCHv2 2/2] iio: accel: kxcjk-1013: add some blank lines for readability

[Daniel Baluta]

On Mon, May 4, 2015 at 12:13 PM, Antonio Ospite <ao2@ao2.it> wrote:
> Some extra blank lines between if checks don't hurt and improve
> readability.
>
> Signed-off-by: Antonio Ospite <ao2@ao2.it>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Bastien Nocera <hadess@hadess.net>
> Cc: linux-iio@vger.kernel.org
> ---

Looks nice :).

Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>

>  drivers/iio/accel/kxcjk-1013.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 5b7a860..937bfc2 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1147,8 +1147,10 @@ static const char *kxcjk1013_match_acpi_device(struct device *dev,
>         id = acpi_match_device(dev->driver->acpi_match_table, dev);
>         if (!id)
>                 return NULL;
> +
>         if (strcmp(id->id, "SMO8500") == 0)
>                 *is_smo8500_device = true;
> +
>         *chipset = (enum kx_chipset)id->driver_data;
>
>         return dev_name(dev);
> @@ -1163,6 +1165,7 @@ static int kxcjk1013_gpio_probe(struct i2c_client *client,
>
>         if (!client)
>                 return -EINVAL;
> +
>         if (data->is_smo8500_device)
>                 return -ENOTSUPP;
>
> --
> 2.1.4
>

Re: [PATCHv2 2/2] iio: accel: kxcjk-1013: add some blank lines for readability

[Jonathan Cameron]

On 04/05/15 11:51, Daniel Baluta wrote:
> On Mon, May 4, 2015 at 12:13 PM, Antonio Ospite <ao2@ao2.it> wrote:
>> Some extra blank lines between if checks don't hurt and improve
>> readability.
>>
>> Signed-off-by: Antonio Ospite <ao2@ao2.it>
>> Cc: Jonathan Cameron <jic23@kernel.org>
>> Cc: Bastien Nocera <hadess@hadess.net>
>> Cc: linux-iio@vger.kernel.org
>> ---
> 
> Looks nice :).
> 
> Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
added to the patch.


> 
>>  drivers/iio/accel/kxcjk-1013.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
>> index 5b7a860..937bfc2 100644
>> --- a/drivers/iio/accel/kxcjk-1013.c
>> +++ b/drivers/iio/accel/kxcjk-1013.c
>> @@ -1147,8 +1147,10 @@ static const char *kxcjk1013_match_acpi_device(struct device *dev,
>>         id = acpi_match_device(dev->driver->acpi_match_table, dev);
>>         if (!id)
>>                 return NULL;
>> +
>>         if (strcmp(id->id, "SMO8500") == 0)
>>                 *is_smo8500_device = true;
>> +
>>         *chipset = (enum kx_chipset)id->driver_data;
>>
>>         return dev_name(dev);
>> @@ -1163,6 +1165,7 @@ static int kxcjk1013_gpio_probe(struct i2c_client *client,
>>
>>         if (!client)
>>                 return -EINVAL;
>> +
>>         if (data->is_smo8500_device)
>>                 return -ENOTSUPP;
>>
>> --
>> 2.1.4
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>