Linux IIO development
 help / color / mirror / Atom feed
* iio: hid: fix the retval in gyro_3d_capture_sample
@ 2023-01-11 12:24 Dmitry Perchanov
  2023-01-14 16:32 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Perchanov @ 2023-01-11 12:24 UTC (permalink / raw)
  To: jic23; +Cc: linux-iio, lars, demisrael

Return value should be zero for success.
This was forgotten for timestamp feature.
Verified on RealSense cameras.

Fixes: 4648cbd8fb92 ("iio: hid-sensor-gyro-3d: Add timestamp channel")

Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
---
 drivers/iio/gyro/hid-sensor-gyro-3d.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
index 8f0ad022c..698c50da1 100644
--- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
+++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
@@ -231,6 +231,7 @@ static int gyro_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
 		gyro_state->timestamp =
 			hid_sensor_convert_timestamp(&gyro_state->common_attributes,
 						     *(s64 *)raw_data);
+		ret = 0;
 	break;
 	default:
 		break;
-- 
2.39.0


---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: iio: hid: fix the retval in gyro_3d_capture_sample
  2023-01-11 12:24 iio: hid: fix the retval in gyro_3d_capture_sample Dmitry Perchanov
@ 2023-01-14 16:32 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2023-01-14 16:32 UTC (permalink / raw)
  To: Dmitry Perchanov; +Cc: linux-iio, lars, demisrael

On Wed, 11 Jan 2023 14:24:25 +0200
Dmitry Perchanov <dmitry.perchanov@intel.com> wrote:

> Return value should be zero for success.
> This was forgotten for timestamp feature.
> Verified on RealSense cameras.
> 
> Fixes: 4648cbd8fb92 ("iio: hid-sensor-gyro-3d: Add timestamp channel")
> 
> Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Applied with patch description white space tidied up (wrap at 75 chars,
not blank lines in tags block).

Applied to the fixes-togreg branch of iio.git and marked for stable
inclusion.

Thanks,

Jonathan

> ---
>  drivers/iio/gyro/hid-sensor-gyro-3d.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> index 8f0ad022c..698c50da1 100644
> --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
> +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> @@ -231,6 +231,7 @@ static int gyro_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
>  		gyro_state->timestamp =
>  			hid_sensor_convert_timestamp(&gyro_state->common_attributes,
>  						     *(s64 *)raw_data);
> +		ret = 0;
>  	break;
>  	default:
>  		break;


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-14 16:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-11 12:24 iio: hid: fix the retval in gyro_3d_capture_sample Dmitry Perchanov
2023-01-14 16:32 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox