Re: [PATCH 1/2] iio: bmi270: suspend and resume triggering on relevant pm operations

[Andy Shevchenko <andy@kernel.org>]

On Fri, May 09, 2025 at 07:15:25PM +0200, Denis Benato wrote:
> Prevent triggers from stop working after the device has entered sleep:
> use iio_device_suspend_triggering and iio_device_resume_triggering helpers.

The cover letter call it a fix, where is the Fixes tag?

...

> +const struct dev_pm_ops bmi270_core_pm_ops = {
> +	RUNTIME_PM_OPS(bmi270_core_runtime_suspend,
> +		       bmi270_core_runtime_resume, NULL)

One line (it's only 85 characters and it's fine in this case).

> +};

...

> --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
> +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
> @@ -52,6 +52,7 @@ static const struct of_device_id bmi270_of_match[] = {
>  static struct i2c_driver bmi270_i2c_driver = {
>  	.driver = {
>  		.name = "bmi270_i2c",
> +		.pm = pm_ptr(&bmi270_core_pm_ops),

Is pm.h included?

>  		.acpi_match_table = bmi270_acpi_match,
>  		.of_match_table = bmi270_of_match,
>  	},
> diff --git a/drivers/iio/imu/bmi270/bmi270_spi.c b/drivers/iio/imu/bmi270/bmi270_spi.c
> index 88a77aba5e4f..b25171413531 100644
> --- a/drivers/iio/imu/bmi270/bmi270_spi.c
> +++ b/drivers/iio/imu/bmi270/bmi270_spi.c
> @@ -79,6 +79,7 @@ static const struct of_device_id bmi270_of_match[] = {
>  static struct spi_driver bmi270_spi_driver = {
>  	.driver = {
>  		.name = "bmi270",
> +		.pm = pm_ptr(&bmi270_core_pm_ops),

Ditto.
>  		.of_match_table = bmi270_of_match,
>  	},
>  	.probe = bmi270_spi_probe,

-- 
With Best Regards,
Andy Shevchenko