Re: [PATCH 1/2] iio: bmi270: suspend and resume triggering on relevant pm operations

[Denis Benato <benato.denis96@gmail.com>]

On 5/12/25 10:54, Andy Shevchenko wrote:
> On Fri, May 09, 2025 at 07:15:25PM +0200, Denis Benato wrote:
>> Prevent triggers from stop working after the device has entered sleep:
>> use iio_device_suspend_triggering and iio_device_resume_triggering helpers.
> The cover letter call it a fix, where is the Fixes tag?
I didn't know if it was okay to use that tag while to root cause is still there and it needs to be fixed for a lot more devices.

I was also attempting to make this patch very similar to accepted one: https://lore.kernel.org/all/20240807185619.7261-3-benato.denis96@gmail.com/

Is fixed tag appropriate?

>
> ...
>
>> +const struct dev_pm_ops bmi270_core_pm_ops = {
>> +	RUNTIME_PM_OPS(bmi270_core_runtime_suspend,
>> +		       bmi270_core_runtime_resume, NULL)
> One line (it's only 85 characters and it's fine in this case).


Okay, will send a new version when I have answer to the above question.


>> +};
> ...
>
>> --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
>> +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
>> @@ -52,6 +52,7 @@ static const struct of_device_id bmi270_of_match[] = {
>>  static struct i2c_driver bmi270_i2c_driver = {
>>  	.driver = {
>>  		.name = "bmi270_i2c",
>> +		.pm = pm_ptr(&bmi270_core_pm_ops),
> Is pm.h included?
I assumed it was not needed since the i2c_driver definition should be enough.


I will include pm.h on the next version, thanks.


>
>>  		.acpi_match_table = bmi270_acpi_match,
>>  		.of_match_table = bmi270_of_match,
>>  	},
>> diff --git a/drivers/iio/imu/bmi270/bmi270_spi.c b/drivers/iio/imu/bmi270/bmi270_spi.c
>> index 88a77aba5e4f..b25171413531 100644
>> --- a/drivers/iio/imu/bmi270/bmi270_spi.c
>> +++ b/drivers/iio/imu/bmi270/bmi270_spi.c
>> @@ -79,6 +79,7 @@ static const struct of_device_id bmi270_of_match[] = {
>>  static struct spi_driver bmi270_spi_driver = {
>>  	.driver = {
>>  		.name = "bmi270",
>> +		.pm = pm_ptr(&bmi270_core_pm_ops),
> Ditto.
>>  		.of_match_table = bmi270_of_match,
>>  	},
>>  	.probe = bmi270_spi_probe,
I don't know how but your answer was lost in my mail.

Sorry for the late response and thank you for your suggestions,
Denis