From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v0 12/14] iio: magnetometer: ak8975: Unify messages with help of dev_err_probe()
Date: Tue, 28 Apr 2026 12:46:56 +0300 [thread overview]
Message-ID: <afCCEMmu07oRV-93@ashevche-desk.local> (raw)
In-Reply-To: <CALoEA-yjpDhTrP1Z-ZgSohjJBE8W+kBvTeeDHtcguvb4ReiV3A@mail.gmail.com>
On Tue, Apr 28, 2026 at 11:21:29AM +0200, Joshua Crofts wrote:
> On Mon, 27 Apr 2026 at 22:14, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...
> > + if (ret)
> > + return dev_err_probe(dev, ret, "%s initialization fails\n", name);
>
> Minor typo, better to have "initialization failed", but that was already
> in the original codebase.
>
> > + if (ret)
> > + return dev_err_probe(dev, ret, "device register failed\n");
>
> Same here, "failed to register device" would probably be better imo.
Hmm... Not sure about these. I would leave as is and do a separate change.
(In principle I agree that messages may be improved.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-28 9:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 20:09 [PATCH v0 00/14] iio: magnetometer: ak8975: Additional changes to the driver Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 01/14] drivers/iio/magnetometer/ak8975.c: fixup for the IWYU change Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 02/14] drivers/iio/magnetometer/ak8975.c: fixup for the errno fix Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 03/14] drivers/iio/magnetometer/ak8975.c: fixup for the iopoll.h conversion Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 04/14] iio: magnetometer: ak8975: Inline timeout constants Andy Shevchenko
2026-04-28 16:22 ` Jonathan Cameron
2026-04-28 17:06 ` Andy Shevchenko
2026-04-29 13:59 ` Joshua Crofts
2026-04-29 14:21 ` Andy Shevchenko
2026-04-29 14:27 ` Joshua Crofts
2026-04-27 20:09 ` [PATCH v0 05/14] iio: magnetometer: ak8975: Avoid using temporary variable Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 06/14] iio: magnetometer: ak8975: Drop duplicate NULL check Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 07/14] iio: magnetometer: ak8975: remove duplicate error message Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 08/14] iio: magnetometer: ak8975: Reduce usage of magic lengths of the buffer Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 09/14] iio: magnetometer: ak8975: Unify return code variable name Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 10/14] iio: magnetometer: ak8975: switch to using managed resources Andy Shevchenko
2026-04-28 16:32 ` Jonathan Cameron
2026-04-29 13:48 ` Joshua Crofts
2026-04-29 14:34 ` Andy Shevchenko
2026-04-29 15:10 ` Jonathan Cameron
2026-04-27 20:09 ` [PATCH v0 11/14] iio: magnetometer: ak8975: Consistently use 'data' parameter Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 12/14] iio: magnetometer: ak8975: Unify messages with help of dev_err_probe() Andy Shevchenko
2026-04-28 9:21 ` Joshua Crofts
2026-04-28 9:46 ` Andy Shevchenko [this message]
2026-04-28 9:52 ` Joshua Crofts
2026-04-27 20:09 ` [PATCH v0 13/14] iio: magnetometer: ak8975: Use temporary variable for struct device Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 14/14] iio: magnetometer: ak8975: Make use of the macros from bits.h Andy Shevchenko
2026-04-28 7:23 ` Joshua Crofts
2026-04-28 7:54 ` Andy Shevchenko
2026-04-27 20:19 ` [PATCH v0 00/14] iio: magnetometer: ak8975: Additional changes to the driver Andy Shevchenko
2026-04-28 6:37 ` Joshua Crofts
2026-04-28 7:03 ` Andy Shevchenko
2026-04-28 7:14 ` Joshua Crofts
2026-04-28 16:16 ` Jonathan Cameron
2026-04-28 16:23 ` Joshua Crofts
2026-04-28 16:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afCCEMmu07oRV-93@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox