public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v0 00/14] iio: magnetometer: ak8975: Additional changes to the driver
Date: Tue, 28 Apr 2026 17:16:26 +0100	[thread overview]
Message-ID: <20260428171626.1fc178d5@jic23-huawei> (raw)
In-Reply-To: <CALoEA-zLo1Neb=6xqwRyNcgsWBdpXPQox3mvJo9pEXs-Y0h__w@mail.gmail.com>

On Tue, 28 Apr 2026 09:14:55 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Tue, 28 Apr 2026 at 09:03, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Tue, Apr 28, 2026 at 08:37:22AM +0200, Joshua Crofts wrote:  
> > > On Mon, 27 Apr 2026 at 22:14, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:  
> > > >
> > > > This series is an attempt to make the driver less a rabbit hole.
> > > > It's a continuation of what Joshua Crofts started doing. Hence
> > > > it is based on his work and first three "patches" here are supposed
> > > > to be folded to his series accordingly.
> > > >
> > > > I have compile-tested them, but I haven't done full double check of
> > > > the correctness from functional point of view. Joshua, please do that
> > > > before incorporating into your series. Yes, my patches are assumed to
> > > > become the part of Joshua's whatever next version of the series, that's
> > > > why mine is marked as v0.
> > > >
> > > > Should not be taken directly by the maintainers, but any comments, review
> > > > are highly appreciated.  
> > >
> > > When you said a few changes, I didn't expect an 11-part series :). I'll go over
> > > them and am them to my branch. I might check out the guard()() and chip_info
> > > changes.  
> >
> > On top of that also one may consider to switching to use reset-gpio instead of
> > poking "reset" GPIO directly. But this sounds like too many for one go, let's
> > make this 17 patch series go (6 yours + 11 mine).  
> 
> Fair enough, perhaps another time.
> 
> BTW, if I'm sending your patches to the list, I should also add a Signed-off-by
> tag to the end, right?
> 
Yes.  You are 'handling' the patches, so need to add your sign off.


  reply	other threads:[~2026-04-28 16:16 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 20:09 [PATCH v0 00/14] iio: magnetometer: ak8975: Additional changes to the driver Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 01/14] drivers/iio/magnetometer/ak8975.c: fixup for the IWYU change Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 02/14] drivers/iio/magnetometer/ak8975.c: fixup for the errno fix Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 03/14] drivers/iio/magnetometer/ak8975.c: fixup for the iopoll.h conversion Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 04/14] iio: magnetometer: ak8975: Inline timeout constants Andy Shevchenko
2026-04-28 16:22   ` Jonathan Cameron
2026-04-28 17:06     ` Andy Shevchenko
2026-04-29 13:59       ` Joshua Crofts
2026-04-29 14:21         ` Andy Shevchenko
2026-04-29 14:27           ` Joshua Crofts
2026-04-27 20:09 ` [PATCH v0 05/14] iio: magnetometer: ak8975: Avoid using temporary variable Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 06/14] iio: magnetometer: ak8975: Drop duplicate NULL check Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 07/14] iio: magnetometer: ak8975: remove duplicate error message Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 08/14] iio: magnetometer: ak8975: Reduce usage of magic lengths of the buffer Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 09/14] iio: magnetometer: ak8975: Unify return code variable name Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 10/14] iio: magnetometer: ak8975: switch to using managed resources Andy Shevchenko
2026-04-28 16:32   ` Jonathan Cameron
2026-04-29 13:48     ` Joshua Crofts
2026-04-29 14:34       ` Andy Shevchenko
2026-04-29 15:10         ` Jonathan Cameron
2026-04-27 20:09 ` [PATCH v0 11/14] iio: magnetometer: ak8975: Consistently use 'data' parameter Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 12/14] iio: magnetometer: ak8975: Unify messages with help of dev_err_probe() Andy Shevchenko
2026-04-28  9:21   ` Joshua Crofts
2026-04-28  9:46     ` Andy Shevchenko
2026-04-28  9:52       ` Joshua Crofts
2026-04-27 20:09 ` [PATCH v0 13/14] iio: magnetometer: ak8975: Use temporary variable for struct device Andy Shevchenko
2026-04-27 20:09 ` [PATCH v0 14/14] iio: magnetometer: ak8975: Make use of the macros from bits.h Andy Shevchenko
2026-04-28  7:23   ` Joshua Crofts
2026-04-28  7:54     ` Andy Shevchenko
2026-04-27 20:19 ` [PATCH v0 00/14] iio: magnetometer: ak8975: Additional changes to the driver Andy Shevchenko
2026-04-28  6:37 ` Joshua Crofts
2026-04-28  7:03   ` Andy Shevchenko
2026-04-28  7:14     ` Joshua Crofts
2026-04-28 16:16       ` Jonathan Cameron [this message]
2026-04-28 16:23         ` Joshua Crofts
2026-04-28 16:35 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260428171626.1fc178d5@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox