* [PATCH v3] iio: accel: adxl355: replace usleep_range() with fsleep()
@ 2026-05-10 11:38 Stepan Ionichev
2026-05-11 7:27 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Stepan Ionichev @ 2026-05-10 11:38 UTC (permalink / raw)
To: jic23
Cc: lars, Michael.Hennerich, puranjay, dlechner, nuno.sa, andy,
linux-iio, linux-kernel, sozdayvek
The "at least 5ms" wait after software reset has no specific upper
bound. Use fsleep() with 5 * USEC_PER_MSEC to make the unit
explicit at the call site.
No functional change.
Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
---
v3:
- Add this changelog (was missing in v2)
v2:
- Use 5 * USEC_PER_MSEC instead of raw 5000
drivers/iio/accel/adxl355_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_core.c
index 8f90c58f4..9d4421653 100644
--- a/drivers/iio/accel/adxl355_core.c
+++ b/drivers/iio/accel/adxl355_core.c
@@ -351,7 +351,7 @@ static int adxl355_setup(struct adxl355_data *data)
return ret;
/* Wait at least 5ms after software reset */
- usleep_range(5000, 10000);
+ fsleep(5 * USEC_PER_MSEC);
/* Read shadow registers for comparison */
ret = regmap_bulk_read(data->regmap,
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] iio: accel: adxl355: replace usleep_range() with fsleep()
2026-05-10 11:38 [PATCH v3] iio: accel: adxl355: replace usleep_range() with fsleep() Stepan Ionichev
@ 2026-05-11 7:27 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-05-11 7:27 UTC (permalink / raw)
To: Stepan Ionichev
Cc: jic23, lars, Michael.Hennerich, puranjay, dlechner, nuno.sa, andy,
linux-iio, linux-kernel
On Sun, May 10, 2026 at 04:38:52PM +0500, Stepan Ionichev wrote:
> The "at least 5ms" wait after software reset has no specific upper
> bound. Use fsleep() with 5 * USEC_PER_MSEC to make the unit
> explicit at the call site.
> No functional change.
Strictly speaking the upper limit is not set as 10 milliseconds now,
but defined by the internals of fsleep(), usually +25%.
Perhaps Jonathan can just drop this sentence from the commit message
whilst applying.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-11 7:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-10 11:38 [PATCH v3] iio: accel: adxl355: replace usleep_range() with fsleep() Stepan Ionichev
2026-05-11 7:27 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox