[PATCH] iio: adc: ad7625: Add ending newlines to error messages

[PATCH] iio: adc: ad7625: Add ending newlines to error messages

[Uwe Kleine-König]

Error messages passed to dev_err_probe() are supposed to end in "\n".
Fix accordingly.

Fixes: b7ffd0fa65e9 ("iio: adc: ad7625: add driver")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
 drivers/iio/adc/ad7625.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/adc/ad7625.c b/drivers/iio/adc/ad7625.c
index aefe3bf75c91..afa9bf4ddf3c 100644
--- a/drivers/iio/adc/ad7625.c
+++ b/drivers/iio/adc/ad7625.c
@@ -477,12 +477,12 @@ static int devm_ad7625_pwm_get(struct device *dev,
 	ref_clk = devm_clk_get_enabled(dev, NULL);
 	if (IS_ERR(ref_clk))
 		return dev_err_probe(dev, PTR_ERR(ref_clk),
-				     "failed to get ref_clk");
+				     "failed to get ref_clk\n");
 
 	ref_clk_rate_hz = clk_get_rate(ref_clk);
 	if (!ref_clk_rate_hz)
 		return dev_err_probe(dev, -EINVAL,
-				     "failed to get ref_clk rate");
+				     "failed to get ref_clk rate\n");
 
 	st->ref_clk_rate_hz = ref_clk_rate_hz;
 
@@ -533,7 +533,7 @@ static int devm_ad7625_regulator_setup(struct device *dev,
 
 	if (!st->info->has_internal_vref && !st->have_refin && !ref_mv)
 		return dev_err_probe(dev, -EINVAL,
-				     "Need either REFIN or REF");
+				     "Need either REFIN or REF\n");
 
 	if (st->have_refin && ref_mv)
 		return dev_err_probe(dev, -EINVAL,
@@ -623,7 +623,7 @@ static int ad7625_probe(struct platform_device *pdev)
 	st->back = devm_iio_backend_get(dev, NULL);
 	if (IS_ERR(st->back))
 		return dev_err_probe(dev, PTR_ERR(st->back),
-				     "failed to get IIO backend");
+				     "failed to get IIO backend\n");
 
 	ret = devm_iio_backend_request_buffer(dev, st->back, indio_dev);
 	if (ret)

base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
-- 
2.45.2

Re: [PATCH] iio: adc: ad7625: Add ending newlines to error messages

[Trevor Gamblin]

On 2024-12-30 10:10, Uwe Kleine-König wrote:
> Error messages passed to dev_err_probe() are supposed to end in "\n".
> Fix accordingly.
>
> Fixes: b7ffd0fa65e9 ("iio: adc: ad7625: add driver")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Tested-by: Trevor Gamblin <tgamblin@baylibre.com>

Re: [PATCH] iio: adc: ad7625: Add ending newlines to error messages

[Jonathan Cameron]

On Mon, 30 Dec 2024 10:15:21 -0500
Trevor Gamblin <tgamblin@baylibre.com> wrote:

> On 2024-12-30 10:10, Uwe Kleine-König wrote:
> > Error messages passed to dev_err_probe() are supposed to end in "\n".
> > Fix accordingly.
> >
> > Fixes: b7ffd0fa65e9 ("iio: adc: ad7625: add driver")
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>  
> Tested-by: Trevor Gamblin <tgamblin@baylibre.com>

Applied.
Thanks,

Re: [PATCH] iio: adc: ad7625: Add ending newlines to error messages

[Andy Shevchenko]

Sat, Jan 04, 2025 at 01:11:32PM +0000, Jonathan Cameron kirjoitti:
> On Mon, 30 Dec 2024 10:15:21 -0500
> Trevor Gamblin <tgamblin@baylibre.com> wrote:
> > On 2024-12-30 10:10, Uwe Kleine-König wrote:
> > > Error messages passed to dev_err_probe() are supposed to end in "\n".
> > > Fix accordingly.
> > >
> > > Fixes: b7ffd0fa65e9 ("iio: adc: ad7625: add driver")
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>  
> > Tested-by: Trevor Gamblin <tgamblin@baylibre.com>

Actually Q to everybody: do you know that "supposed" in this commit message is
just a good style as dev_*() are all automatically add newline AFAICS?

P.S. Recently discussed this topic with Linus W. and if I'm not mistaken one
should never see an issue with those messages in the dmesg. OTOH, all other
means that try to save or do anything with messages w/o \n should be aware.

-- 
With Best Regards,
Andy Shevchenko