* [PATCH] iio: Fix build error for ltc2664
@ 2024-10-23 8:23 Jinjie Ruan
2024-10-23 8:41 ` Javier Carrasco
0 siblings, 1 reply; 3+ messages in thread
From: Jinjie Ruan @ 2024-10-23 8:23 UTC (permalink / raw)
To: jic23, lars, paul.walmsley, palmer, aou, javier.carrasco.cruz,
nuno.sa, conor.dooley, michael.hennerich, anshulusr, sunke,
kimseer.paller, linux-iio, linux-kernel, linux-riscv
Cc: ruanjinjie
If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:
riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in function `ltc2664_probe':
ltc2664.c:(.text+0x714): undefined reference to `__devm_regmap_init_spi'
Select REGMAP_SPI for LTC2664 to fix it.
Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/iio/dac/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index 45e337c6d256..ae6d04c758d1 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -381,6 +381,7 @@ config LTC2664
tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
depends on SPI
select REGMAP
+ select REGMAP_SPI
help
Say yes here to build support for Analog Devices
LTC2664 and LTC2672 converters (DAC).
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: Fix build error for ltc2664
2024-10-23 8:23 [PATCH] iio: Fix build error for ltc2664 Jinjie Ruan
@ 2024-10-23 8:41 ` Javier Carrasco
2024-10-23 10:17 ` Nuno Sá
0 siblings, 1 reply; 3+ messages in thread
From: Javier Carrasco @ 2024-10-23 8:41 UTC (permalink / raw)
To: Jinjie Ruan, jic23, lars, paul.walmsley, palmer, aou, nuno.sa,
conor.dooley, michael.hennerich, anshulusr, sunke, kimseer.paller,
linux-iio, linux-kernel, linux-riscv
On 23/10/2024 10:23, Jinjie Ruan wrote:
> If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:
>
> riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in function `ltc2664_probe':
> ltc2664.c:(.text+0x714): undefined reference to `__devm_regmap_init_spi'
>
> Select REGMAP_SPI for LTC2664 to fix it.
>
> Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> drivers/iio/dac/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 45e337c6d256..ae6d04c758d1 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -381,6 +381,7 @@ config LTC2664
> tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
> depends on SPI
> select REGMAP
> + select REGMAP_SPI
Should you not replace REGMAP with REGMAP_SPI instead?
> help
> Say yes here to build support for Analog Devices
> LTC2664 and LTC2672 converters (DAC).
Best regards,
Javier Carrasco
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: Fix build error for ltc2664
2024-10-23 8:41 ` Javier Carrasco
@ 2024-10-23 10:17 ` Nuno Sá
0 siblings, 0 replies; 3+ messages in thread
From: Nuno Sá @ 2024-10-23 10:17 UTC (permalink / raw)
To: Javier Carrasco, Jinjie Ruan, jic23, lars, paul.walmsley, palmer,
aou, nuno.sa, conor.dooley, michael.hennerich, anshulusr, sunke,
kimseer.paller, linux-iio, linux-kernel, linux-riscv
On Wed, 2024-10-23 at 10:41 +0200, Javier Carrasco wrote:
> On 23/10/2024 10:23, Jinjie Ruan wrote:
> > If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:
> >
> > riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in
> > function `ltc2664_probe':
> > ltc2664.c:(.text+0x714): undefined reference to
> > `__devm_regmap_init_spi'
> >
> > Select REGMAP_SPI for LTC2664 to fix it.
> >
> > Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and
> > LTC2672")
> > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> > ---
> > drivers/iio/dac/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> > index 45e337c6d256..ae6d04c758d1 100644
> > --- a/drivers/iio/dac/Kconfig
> > +++ b/drivers/iio/dac/Kconfig
> > @@ -381,6 +381,7 @@ config LTC2664
> > tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
> > depends on SPI
> > select REGMAP
> > + select REGMAP_SPI
>
> Should you not replace REGMAP with REGMAP_SPI instead?
Yes, I think so... The commit title could also be improved
"iio: dac: kconfig: ..."
With that:
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
>
> > help
> > Say yes here to build support for Analog Devices
> > LTC2664 and LTC2672 converters (DAC).
>
>
> Best regards,
> Javier Carrasco
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-23 10:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-23 8:23 [PATCH] iio: Fix build error for ltc2664 Jinjie Ruan
2024-10-23 8:41 ` Javier Carrasco
2024-10-23 10:17 ` Nuno Sá
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox