Linux Input/HID development
 help / color / mirror / Atom feed
From: Yuugo Yoneda via B4 Relay <devnull+yogo.0917.sabu.gmail.com@kernel.org>
To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>,  Radu Rendec <radu@rendec.net>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	 Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Ulf Hansson <ulfh@kernel.org>,
	 Adrian Hunter <adrian.hunter@intel.com>,
	Jonathan Corbet <corbet@lwn.net>,
	 Shuah Khan <skhan@linuxfoundation.org>,
	 Randy Dunlap <rdunlap@infradead.org>,
	Russell King <linux@armlinux.org.uk>,
	 Arnd Bergmann <arnd@arndb.de>,
	 Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 Linus Walleij <linusw@kernel.org>,
	Drew Fustini <fustini@kernel.org>,
	 linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	 linux-mmc@vger.kernel.org, linux-doc@vger.kernel.org,
	soc@lists.linux.dev
Subject: [PATCH RFC v2 04/13] irqchip: add SiRF AT550 interrupt controller driver
Date: Sat, 21 Nov 2026 21:43:14 +0900	[thread overview]
Message-ID: <20261121-at550-rfc-v1-v2-4-b0309d0789b2@gmail.com> (raw)
In-Reply-To: <20261121-at550-rfc-v1-v2-0-b0309d0789b2@gmail.com>

From: Yuugo Yoneda <yogo.0917.sabu@gmail.com>

Add an irqchip driver for the SiRF AT550 interrupt controller using
IRQCHIP_DECLARE and a linear IRQ domain.

Validate the chip ID register before touching mask/level registers, mask
both 32-source banks during setup, route sources to IRQ while leaving
DSP mask registers untouched, set IRQ_LEVEL on mapped descriptors, and
bound the dispatch loop.

Signed-off-by: Yuugo Yoneda <yogo.0917.sabu@gmail.com>
---
 MAINTAINERS                 |   1 +
 drivers/irqchip/Kconfig     |   5 ++
 drivers/irqchip/Makefile    |   2 +
 drivers/irqchip/irq-at550.c | 111 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 119 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e052d9dde..354466e29 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -25852,6 +25852,7 @@ M:	Yuugo Yoneda <yogo.0917.sabu@gmail.com>
 S:	Odd Fixes
 F:	Documentation/devicetree/bindings/arm/sirf,at550.yaml
 F:	Documentation/devicetree/bindings/interrupt-controller/sirf,at550-intc.yaml
+F:	drivers/irqchip/irq-at550.c
 
 SIS 190 ETHERNET DRIVER
 M:	Francois Romieu <romieu@fr.zoreil.com>
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 136bab41f..abf704110 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -852,4 +852,9 @@ config IRQCHIP_XILINX_SMMU_CSR
 	  ZynqMP-class platforms where a vendor CSR block mediates SMMU
 	  interrupts.
 
+config AT550_IRQ
+	bool
+	depends on ARM
+	select IRQ_DOMAIN
+
 endmenu
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 16a5fd126..0aa36c7b8 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -136,3 +136,5 @@ obj-$(CONFIG_MCHP_EIC)			+= irq-mchp-eic.o
 obj-$(CONFIG_SOPHGO_SG2042_MSI)		+= irq-sg2042-msi.o
 obj-$(CONFIG_SUNPLUS_SP7021_INTC)	+= irq-sp7021-intc.o
 obj-$(CONFIG_IRQCHIP_XILINX_SMMU_CSR)	+= irq-xilinx-smmu-csr.o
+
+obj-$(CONFIG_AT550_IRQ) += irq-at550.o
diff --git a/drivers/irqchip/irq-at550.c b/drivers/irqchip/irq-at550.c
new file mode 100644
index 000000000..c9205ff12
--- /dev/null
+++ b/drivers/irqchip/irq-at550.c
@@ -0,0 +1,111 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/* SiRF AT550 interrupt controller. */
+#include <linux/io.h>
+#include <linux/irq.h>
+#include <linux/irqchip.h>
+#include <linux/irqdomain.h>
+#include <linux/of_address.h>
+#include <asm/exception.h>
+
+#define AT550_IRQ_COUNT	64
+#define AT550_MASK	0x18
+#define AT550_LEVEL	0x20
+#define AT550_CHIP_ID	0x34
+#define AT550_IRQ_ID	0x38
+
+static void __iomem *at550_intc;
+static struct irq_domain *at550_domain;
+
+static void at550_irq_mask(struct irq_data *data)
+{
+	void __iomem *reg = at550_intc + AT550_MASK + (data->hwirq / 32) * 4;
+
+	writel(readl(reg) & ~BIT(data->hwirq % 32), reg);
+}
+
+static void at550_irq_unmask(struct irq_data *data)
+{
+	void __iomem *reg = at550_intc + AT550_MASK + (data->hwirq / 32) * 4;
+
+	writel(readl(reg) | BIT(data->hwirq % 32), reg);
+}
+
+static struct irq_chip at550_chip = {
+	.name = "at550-intc",
+	.irq_mask = at550_irq_mask,
+	.irq_unmask = at550_irq_unmask,
+};
+
+static int at550_irq_map(struct irq_domain *domain, unsigned int irq,
+			irq_hw_number_t hwirq)
+{
+	if (hwirq >= AT550_IRQ_COUNT)
+		return -EINVAL;
+	irq_set_status_flags(irq, IRQ_LEVEL);
+	irq_set_chip_and_handler(irq, &at550_chip, handle_level_irq);
+	irq_set_noprobe(irq);
+	return 0;
+}
+
+static const struct irq_domain_ops at550_domain_ops = {
+	.map = at550_irq_map,
+	.xlate = irq_domain_xlate_onecell,
+};
+
+static void __exception_irq_entry at550_handle_irq(struct pt_regs *regs)
+{
+	unsigned int count, hwirq;
+
+	for (count = 0; count < AT550_IRQ_COUNT; count++) {
+		hwirq = readl(at550_intc + AT550_IRQ_ID) & 0xff;
+		if (hwirq == 0xff)
+			return;
+		if (hwirq >= AT550_IRQ_COUNT) {
+			pr_err_ratelimited("at550-intc: invalid source %u\n", hwirq);
+			return;
+		}
+		if (generic_handle_domain_irq(at550_domain, hwirq))
+			return;
+	}
+}
+
+static int __init at550_irq_init(struct device_node *node,
+				struct device_node *parent)
+{
+	int ret;
+
+	if (parent || at550_intc)
+		return -EINVAL;
+	at550_intc = of_iomap(node, 0);
+	if (!at550_intc)
+		return -ENOMEM;
+	if ((readl(at550_intc + AT550_CHIP_ID) & 0xffff) != 0x1230) {
+		ret = -ENODEV;
+		goto unmap;
+	}
+	/* A set mask bit enables a source; clear level bits route it to IRQ. */
+	writel(0, at550_intc + AT550_MASK);
+	writel(0, at550_intc + AT550_MASK + 4);
+	writel(0, at550_intc + AT550_LEVEL);
+	writel(0, at550_intc + AT550_LEVEL + 4);
+	at550_domain = irq_domain_create_linear(of_fwnode_handle(node), AT550_IRQ_COUNT,
+					   &at550_domain_ops, NULL);
+	if (!at550_domain) {
+		ret = -ENOMEM;
+		goto unmap;
+	}
+	ret = set_handle_irq(at550_handle_irq);
+	if (ret)
+		goto remove_domain;
+	irq_set_default_domain(at550_domain);
+	return 0;
+
+remove_domain:
+	irq_domain_remove(at550_domain);
+	at550_domain = NULL;
+unmap:
+	iounmap(at550_intc);
+	at550_intc = NULL;
+	return ret;
+}
+IRQCHIP_DECLARE(at550, "sirf,at550-intc", at550_irq_init);

-- 
2.56.0



  parent reply	other threads:[~2026-11-21 12:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 12:43 [PATCH RFC v2 00/13] SiRF AT550 / YPL514si initial RAM-boot platform support Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 01/13] dt-bindings: vendor-prefixes: add Yupiteru Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 02/13] dt-bindings: arm: add SiRF AT550 and Yupiteru YPL514si Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 03/13] dt-bindings: interrupt-controller: add SiRF AT550 interrupt controller Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` Yuugo Yoneda via B4 Relay [this message]
2026-11-21 12:43 ` [PATCH RFC v2 05/13] dt-bindings: timer: add SiRF AT550 system timer Yuugo Yoneda via B4 Relay
2026-11-21 12:48   ` sashiko-bot
2026-11-21 12:43 ` [PATCH RFC v2 06/13] clocksource/drivers/timer-at550: add SiRF AT550 counter and match timer Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 07/13] dt-bindings: input: touchscreen: add SiRF AT550 touchscreen Yuugo Yoneda via B4 Relay
2026-11-21 12:48   ` sashiko-bot
2026-11-21 12:43 ` [PATCH RFC v2 08/13] Input: add polled SiRF AT550 resistive touchscreen driver Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 09/13] dt-bindings: mmc: add SiRF AT550 SDHCI host controller Yuugo Yoneda via B4 Relay
2026-11-21 12:48   ` sashiko-bot
2026-11-21 12:43 ` [PATCH RFC v2 10/13] mmc: sdhci-at550: add SiRF AT550 programmed-I/O host driver Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 11/13] ARM: at550: add SiRF AT550 platform support Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 12/13] ARM: dts: sirf: add SiRF AT550 SoC and Yupiteru YPL514si board Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 13/13] ARM: configs: add at550_defconfig Yuugo Yoneda via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121-at550-rfc-v1-v2-4-b0309d0789b2@gmail.com \
    --to=devnull+yogo.0917.sabu.gmail.com@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel.lezcano@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=fustini@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=radu@rendec.net \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=soc@lists.linux.dev \
    --cc=tglx@kernel.org \
    --cc=ulfh@kernel.org \
    --cc=yogo.0917.sabu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox