* [PATCH -next 2/4] Input: bcm-keypad - Switch to use dev_err_probe() helper
2022-09-20 15:30 [PATCH -next 1/4] Input: adc-joystick - Switch to use dev_err_probe() helper Yang Yingliang
@ 2022-09-20 15:30 ` Yang Yingliang
2022-09-22 8:47 ` Mattijs Korpershoek
2022-09-20 15:30 ` [PATCH -next 3/4] Input: gpio_keys " Yang Yingliang
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Yang Yingliang @ 2022-09-20 15:30 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/input/keyboard/bcm-keypad.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c
index 56a919ec23b5..bc8bd78d74f5 100644
--- a/drivers/input/keyboard/bcm-keypad.c
+++ b/drivers/input/keyboard/bcm-keypad.c
@@ -368,11 +368,9 @@ static int bcm_kp_probe(struct platform_device *pdev)
kp->clk = devm_clk_get(&pdev->dev, "peri_clk");
if (IS_ERR(kp->clk)) {
error = PTR_ERR(kp->clk);
- if (error != -ENOENT) {
- if (error != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Failed to get clock\n");
- return error;
- }
+ if (error != -ENOENT)
+ return dev_err_probe(&pdev->dev, error,
+ "Failed to get clock\n");
dev_dbg(&pdev->dev,
"No clock specified. Assuming it's enabled\n");
kp->clk = NULL;
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH -next 2/4] Input: bcm-keypad - Switch to use dev_err_probe() helper
2022-09-20 15:30 ` [PATCH -next 2/4] Input: bcm-keypad " Yang Yingliang
@ 2022-09-22 8:47 ` Mattijs Korpershoek
0 siblings, 0 replies; 10+ messages in thread
From: Mattijs Korpershoek @ 2022-09-22 8:47 UTC (permalink / raw)
To: Yang Yingliang, linux-input; +Cc: dmitry.torokhov
Hi Yang,
Thank you for your patch,
On Tue, Sep 20, 2022 at 23:30, Yang Yingliang <yangyingliang@huawei.com> wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/input/keyboard/bcm-keypad.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c
> index 56a919ec23b5..bc8bd78d74f5 100644
> --- a/drivers/input/keyboard/bcm-keypad.c
> +++ b/drivers/input/keyboard/bcm-keypad.c
> @@ -368,11 +368,9 @@ static int bcm_kp_probe(struct platform_device *pdev)
> kp->clk = devm_clk_get(&pdev->dev, "peri_clk");
> if (IS_ERR(kp->clk)) {
> error = PTR_ERR(kp->clk);
> - if (error != -ENOENT) {
> - if (error != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Failed to get clock\n");
> - return error;
> - }
> + if (error != -ENOENT)
> + return dev_err_probe(&pdev->dev, error,
> + "Failed to get clock\n");
If we look at the input tree, we can see that there is no occurence of
dev_err_probe():
$ ~/src/linux/drivers/input/ 483fed3b5dc8 grep -rsn dev_err_probe
$ ~/src/linux/drivers/input/ 483fed3b5dc8
The reason for this is that the input maintainer (Dmitry) dislikes
dev_err_probe() as he stated in [1]
So I don't think he will apply this.
Regards,
Mattijs
[1] https://lore.kernel.org/r/YWTpg35wyYS1uoFZ@google.com
> dev_dbg(&pdev->dev,
> "No clock specified. Assuming it's enabled\n");
> kp->clk = NULL;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -next 3/4] Input: gpio_keys - Switch to use dev_err_probe() helper
2022-09-20 15:30 [PATCH -next 1/4] Input: adc-joystick - Switch to use dev_err_probe() helper Yang Yingliang
2022-09-20 15:30 ` [PATCH -next 2/4] Input: bcm-keypad " Yang Yingliang
@ 2022-09-20 15:30 ` Yang Yingliang
2022-09-22 8:48 ` Mattijs Korpershoek
2022-09-20 15:30 ` [PATCH -next 4/4] Input: gpio_keys_polled " Yang Yingliang
2022-09-22 8:46 ` [PATCH -next 1/4] Input: adc-joystick " Mattijs Korpershoek
3 siblings, 1 reply; 10+ messages in thread
From: Yang Yingliang @ 2022-09-20 15:30 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/input/keyboard/gpio_keys.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index a5dc4ab87fa1..ac74e85006a8 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -530,10 +530,8 @@ static int gpio_keys_setup_key(struct platform_device *pdev,
*/
bdata->gpiod = NULL;
} else {
- if (error != -EPROBE_DEFER)
- dev_err(dev, "failed to get gpio: %d\n",
- error);
- return error;
+ return dev_err_probe(dev, error,
+ "failed to get gpio\n");
}
}
} else if (gpio_is_valid(button->gpio)) {
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH -next 3/4] Input: gpio_keys - Switch to use dev_err_probe() helper
2022-09-20 15:30 ` [PATCH -next 3/4] Input: gpio_keys " Yang Yingliang
@ 2022-09-22 8:48 ` Mattijs Korpershoek
2022-09-22 8:52 ` Mattijs Korpershoek
0 siblings, 1 reply; 10+ messages in thread
From: Mattijs Korpershoek @ 2022-09-22 8:48 UTC (permalink / raw)
To: Yang Yingliang, linux-input; +Cc: dmitry.torokhov
Hi Yang,
Thank you for your patch,
On Tue, Sep 20, 2022 at 23:30, Yang Yingliang <yangyingliang@huawei.com> wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/input/keyboard/gpio_keys.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
> index a5dc4ab87fa1..ac74e85006a8 100644
> --- a/drivers/input/keyboard/gpio_keys.c
> +++ b/drivers/input/keyboard/gpio_keys.c
> @@ -530,10 +530,8 @@ static int gpio_keys_setup_key(struct platform_device *pdev,
> */
> bdata->gpiod = NULL;
> } else {
> - if (error != -EPROBE_DEFER)
> - dev_err(dev, "failed to get gpio: %d\n",
> - error);
> - return error;
> + return dev_err_probe(dev, error,
> + "failed to get gpio\n");
If we look at the input tree, we can see that there is no occurence of
dev_err_probe():
$ ~/src/linux/drivers/input/ 483fed3b5dc8 grep -rsn dev_err_probe
$ ~/src/linux/drivers/input/ 483fed3b5dc8
The reason for this is that the input maintainer (Dmitry) dislikes
dev_err_probe() as he stated in [1]
So I don't think he will apply this.
Regards,
Mattijs
> }
> }
> } else if (gpio_is_valid(button->gpio)) {
> --
> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH -next 3/4] Input: gpio_keys - Switch to use dev_err_probe() helper
2022-09-22 8:48 ` Mattijs Korpershoek
@ 2022-09-22 8:52 ` Mattijs Korpershoek
0 siblings, 0 replies; 10+ messages in thread
From: Mattijs Korpershoek @ 2022-09-22 8:52 UTC (permalink / raw)
To: Yang Yingliang, linux-input; +Cc: dmitry.torokhov
On Thu, Sep 22, 2022 at 10:48, Mattijs Korpershoek <mkorpershoek@baylibre.com> wrote:
> Hi Yang,
>
> Thank you for your patch,
>
> On Tue, Sep 20, 2022 at 23:30, Yang Yingliang <yangyingliang@huawei.com> wrote:
>
>> In the probe path, dev_err() can be replaced with dev_err_probe()
>> which will check if error code is -EPROBE_DEFER and prints the
>> error name. It also sets the defer probe reason which can be
>> checked later through debugfs.
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> drivers/input/keyboard/gpio_keys.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
>> index a5dc4ab87fa1..ac74e85006a8 100644
>> --- a/drivers/input/keyboard/gpio_keys.c
>> +++ b/drivers/input/keyboard/gpio_keys.c
>> @@ -530,10 +530,8 @@ static int gpio_keys_setup_key(struct platform_device *pdev,
>> */
>> bdata->gpiod = NULL;
>> } else {
>> - if (error != -EPROBE_DEFER)
>> - dev_err(dev, "failed to get gpio: %d\n",
>> - error);
>> - return error;
>> + return dev_err_probe(dev, error,
>> + "failed to get gpio\n");
>
> If we look at the input tree, we can see that there is no occurence of
> dev_err_probe():
>
> $ ~/src/linux/drivers/input/ 483fed3b5dc8 grep -rsn dev_err_probe
> $ ~/src/linux/drivers/input/ 483fed3b5dc8
>
> The reason for this is that the input maintainer (Dmitry) dislikes
> dev_err_probe() as he stated in [1]
>
> So I don't think he will apply this.
>
> Regards,
> Mattijs
Argh, I missed the link. here it is:
[1] https://lore.kernel.org/r/YWTpg35wyYS1uoFZ@google.com
>
>> }
>> }
>> } else if (gpio_is_valid(button->gpio)) {
>> --
>> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -next 4/4] Input: gpio_keys_polled - Switch to use dev_err_probe() helper
2022-09-20 15:30 [PATCH -next 1/4] Input: adc-joystick - Switch to use dev_err_probe() helper Yang Yingliang
2022-09-20 15:30 ` [PATCH -next 2/4] Input: bcm-keypad " Yang Yingliang
2022-09-20 15:30 ` [PATCH -next 3/4] Input: gpio_keys " Yang Yingliang
@ 2022-09-20 15:30 ` Yang Yingliang
2022-09-22 8:48 ` Mattijs Korpershoek
2022-09-22 8:46 ` [PATCH -next 1/4] Input: adc-joystick " Mattijs Korpershoek
3 siblings, 1 reply; 10+ messages in thread
From: Yang Yingliang @ 2022-09-20 15:30 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/input/keyboard/gpio_keys_polled.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c
index c3937d2fc744..ba00ecfbd343 100644
--- a/drivers/input/keyboard/gpio_keys_polled.c
+++ b/drivers/input/keyboard/gpio_keys_polled.c
@@ -299,13 +299,9 @@ static int gpio_keys_polled_probe(struct platform_device *pdev)
NULL, GPIOD_IN,
button->desc);
if (IS_ERR(bdata->gpiod)) {
- error = PTR_ERR(bdata->gpiod);
- if (error != -EPROBE_DEFER)
- dev_err(dev,
- "failed to get gpio: %d\n",
- error);
fwnode_handle_put(child);
- return error;
+ return dev_err_probe(dev, PTR_ERR(bdata->gpiod),
+ "failed to get gpio\n");
}
} else if (gpio_is_valid(button->gpio)) {
/*
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH -next 4/4] Input: gpio_keys_polled - Switch to use dev_err_probe() helper
2022-09-20 15:30 ` [PATCH -next 4/4] Input: gpio_keys_polled " Yang Yingliang
@ 2022-09-22 8:48 ` Mattijs Korpershoek
2022-09-22 8:52 ` Mattijs Korpershoek
0 siblings, 1 reply; 10+ messages in thread
From: Mattijs Korpershoek @ 2022-09-22 8:48 UTC (permalink / raw)
To: Yang Yingliang, linux-input; +Cc: dmitry.torokhov
Hi Yang,
Thank you for your patch,
On Tue, Sep 20, 2022 at 23:30, Yang Yingliang <yangyingliang@huawei.com> wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/input/keyboard/gpio_keys_polled.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c
> index c3937d2fc744..ba00ecfbd343 100644
> --- a/drivers/input/keyboard/gpio_keys_polled.c
> +++ b/drivers/input/keyboard/gpio_keys_polled.c
> @@ -299,13 +299,9 @@ static int gpio_keys_polled_probe(struct platform_device *pdev)
> NULL, GPIOD_IN,
> button->desc);
> if (IS_ERR(bdata->gpiod)) {
> - error = PTR_ERR(bdata->gpiod);
> - if (error != -EPROBE_DEFER)
> - dev_err(dev,
> - "failed to get gpio: %d\n",
> - error);
> fwnode_handle_put(child);
> - return error;
> + return dev_err_probe(dev, PTR_ERR(bdata->gpiod),
> + "failed to get gpio\n");
If we look at the input tree, we can see that there is no occurence of
dev_err_probe():
$ ~/src/linux/drivers/input/ 483fed3b5dc8 grep -rsn dev_err_probe
$ ~/src/linux/drivers/input/ 483fed3b5dc8
The reason for this is that the input maintainer (Dmitry) dislikes
dev_err_probe() as he stated in [1]
So I don't think he will apply this.
Regards,
Mattijs
> }
> } else if (gpio_is_valid(button->gpio)) {
> /*
> --
> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH -next 4/4] Input: gpio_keys_polled - Switch to use dev_err_probe() helper
2022-09-22 8:48 ` Mattijs Korpershoek
@ 2022-09-22 8:52 ` Mattijs Korpershoek
0 siblings, 0 replies; 10+ messages in thread
From: Mattijs Korpershoek @ 2022-09-22 8:52 UTC (permalink / raw)
To: Yang Yingliang, linux-input; +Cc: dmitry.torokhov
On Thu, Sep 22, 2022 at 10:48, Mattijs Korpershoek <mkorpershoek@baylibre.com> wrote:
> Hi Yang,
>
> Thank you for your patch,
>
> On Tue, Sep 20, 2022 at 23:30, Yang Yingliang <yangyingliang@huawei.com> wrote:
>
>> In the probe path, dev_err() can be replaced with dev_err_probe()
>> which will check if error code is -EPROBE_DEFER and prints the
>> error name. It also sets the defer probe reason which can be
>> checked later through debugfs.
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> drivers/input/keyboard/gpio_keys_polled.c | 8 ++------
>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c
>> index c3937d2fc744..ba00ecfbd343 100644
>> --- a/drivers/input/keyboard/gpio_keys_polled.c
>> +++ b/drivers/input/keyboard/gpio_keys_polled.c
>> @@ -299,13 +299,9 @@ static int gpio_keys_polled_probe(struct platform_device *pdev)
>> NULL, GPIOD_IN,
>> button->desc);
>> if (IS_ERR(bdata->gpiod)) {
>> - error = PTR_ERR(bdata->gpiod);
>> - if (error != -EPROBE_DEFER)
>> - dev_err(dev,
>> - "failed to get gpio: %d\n",
>> - error);
>> fwnode_handle_put(child);
>> - return error;
>> + return dev_err_probe(dev, PTR_ERR(bdata->gpiod),
>> + "failed to get gpio\n");
>
> If we look at the input tree, we can see that there is no occurence of
> dev_err_probe():
>
> $ ~/src/linux/drivers/input/ 483fed3b5dc8 grep -rsn dev_err_probe
> $ ~/src/linux/drivers/input/ 483fed3b5dc8
>
> The reason for this is that the input maintainer (Dmitry) dislikes
> dev_err_probe() as he stated in [1]
>
> So I don't think he will apply this.
>
> Regards,
> Mattijs
Argh, I missed the link. here it is:
[1] https://lore.kernel.org/r/YWTpg35wyYS1uoFZ@google.com
>
>> }
>> } else if (gpio_is_valid(button->gpio)) {
>> /*
>> --
>> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH -next 1/4] Input: adc-joystick - Switch to use dev_err_probe() helper
2022-09-20 15:30 [PATCH -next 1/4] Input: adc-joystick - Switch to use dev_err_probe() helper Yang Yingliang
` (2 preceding siblings ...)
2022-09-20 15:30 ` [PATCH -next 4/4] Input: gpio_keys_polled " Yang Yingliang
@ 2022-09-22 8:46 ` Mattijs Korpershoek
3 siblings, 0 replies; 10+ messages in thread
From: Mattijs Korpershoek @ 2022-09-22 8:46 UTC (permalink / raw)
To: Yang Yingliang, linux-input; +Cc: dmitry.torokhov
Hi Yang,
Thank you for your patch,
On Tue, Sep 20, 2022 at 23:30, Yang Yingliang <yangyingliang@huawei.com> wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/input/joystick/adc-joystick.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/input/joystick/adc-joystick.c b/drivers/input/joystick/adc-joystick.c
> index c0deff5d4282..3590d845e381 100644
> --- a/drivers/input/joystick/adc-joystick.c
> +++ b/drivers/input/joystick/adc-joystick.c
> @@ -201,12 +201,9 @@ static int adc_joystick_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> joy->chans = devm_iio_channel_get_all(dev);
> - if (IS_ERR(joy->chans)) {
> - error = PTR_ERR(joy->chans);
> - if (error != -EPROBE_DEFER)
> - dev_err(dev, "Unable to get IIO channels");
> - return error;
> - }
> + if (IS_ERR(joy->chans))
> + return dev_err_probe(dev, PTR_ERR(joy->chans),
> + "Unable to get IIO channels\n");
If we look at the input tree, we can see that there is no occurence of
dev_err_probe():
$ ~/src/linux/drivers/input/ 483fed3b5dc8 grep -rsn dev_err_probe
$ ~/src/linux/drivers/input/ 483fed3b5dc8
The reason for this is that the input maintainer (Dmitry) dislikes
dev_err_probe() as he stated in [1]
So I don't think he will apply this.
Regards,
Mattijs
[1] https://lore.kernel.org/r/YWTpg35wyYS1uoFZ@google.com
>
> error = device_property_read_u32(dev, "poll-interval", &poll_interval);
> if (error) {
> --
> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread