Re: [PATCH 00/11] HID: iio: warning clean up and prefer kernel coding style

[Sanjay Chitroda <sanjayembeddedse@gmail.com>]

On 17 June 2026 1:00:37 pm IST, Maxwell Doose <m32285159@gmail.com> wrote:
>On Tue, Jun 16, 2026 at 5:26 AM Sanjay Chitroda
><sanjayembeddedse@gmail.com> wrote:
>>
>> Hi all,
>>
>> This series updates HID IIO drivers to resolve checkpatch and
>> kernel coding style issue.
>>
>> This improves readability and follow standard kernel coding style
>> No functional changes are introduced.
>>
>> Testing:
>>   - Compiled with W=1 for each patch in the series
>>
>> ---
>> Sanjay Chitroda (11):
>>       iio: hid-sensors: add missing blank line after declarations
>>       iio: humidity: hid-sensor-humidity: align parenthesis for readability
>>       iio: gyro: hid-sensor-gyro-3d: align parenthesis for readability
>>       iio: magnetometer: hid-sensor-magn-3d: align parenthesis for readability
>>       iio: humidity: hid-sensor-humidity: use common device for devres
>>       iio: position: hid-sensor-custom-intel-hinge: use common device for devres
>>       iio: temperature: hid-sensor-temperature: use common device for devres
>>       iio: hid-sensor-magn-3d: use ! instead of explicit NULL check
>>       iio: hid-sensor-rotation: use ! instead of explicit NULL check
>>       iio: hid-sensor-incl-3d: use ! instead of explicit NULL check
>>       iio: hid-sensor-accel-3d: use ! instead of explicit NULL check
>>
>>  drivers/iio/accel/hid-sensor-accel-3d.c            |  2 +-
>>  .../iio/common/hid-sensors/hid-sensor-trigger.c    |  3 +
>>  drivers/iio/gyro/hid-sensor-gyro-3d.c              | 58 ++++++++--------
>>  drivers/iio/humidity/hid-sensor-humidity.c         | 48 ++++++-------
>>  drivers/iio/magnetometer/hid-sensor-magn-3d.c      | 80 +++++++++++-----------
>>  drivers/iio/orientation/hid-sensor-incl-3d.c       |  2 +-
>>  drivers/iio/orientation/hid-sensor-rotation.c      |  2 +-
>>  .../iio/position/hid-sensor-custom-intel-hinge.c   |  2 +-
>>  drivers/iio/temperature/hid-sensor-temperature.c   |  4 +-
>>  9 files changed, 102 insertions(+), 99 deletions(-)
>
>Firstly, for all of the style patches  (1-4, 8-11):
>
>Reviewed-by: Maxwell Doose <m32285159@gmail.com>
>
Hi Maxwell,
Thank you for the review.

>with Andy's comments.
>
>Secondly, the style fixes are all churn. It would honestly be much
>much better if you were to squash those (even despite the
>one-logical-change-per-patch rule).
I agree with squashing 1-4, common HID drivers-specific changes which cover all HID IIO drivers.

However, this series updates 4 HID drivers, while several other HID IIO drivers needs coding style cleanup.
I'd like to ask Jonathan for his opinion on whether all alignment coding style should be handled in single change, individual change or some logic specific HIO IIO drivers split.

Additionally, 5-7 haven't received any comment/tag. I can consider all changes in v2 and also rebase on latest iio/testing tree to incorporate u32 usage_id change.

Thanks, Sanjay
>