From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: Linmao Li <lilinmao@kylinos.cn>, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: byd - synchronize timer deletion before freeing private data
Date: Sun, 19 Jul 2026 22:18:03 -0700 [thread overview]
Message-ID: <al2hgrtDg3uSgbVR@google.com> (raw)
In-Reply-To: <20260720034855.07D8C1F000E9@smtp.kernel.org>
On Mon, Jul 20, 2026 at 03:48:54AM +0000, sashiko-bot@kernel.org wrote:
>
> Should this use timer_shutdown_sync() instead to permanently prevent the timer
> from being re-armed during teardown?
This is a good suggestion.
>
> > kfree(psmouse->private);
> > psmouse->private = NULL;
>
> [Severity: High]
> This is a pre-existing issue, but is it possible for an interrupt to trigger
> byd_process_byte() concurrently with or immediately after freeing this memory?
This has to be solved in psmouse core, I'll take a look.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-07-20 5:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 3:30 [PATCH] Input: byd - synchronize timer deletion before freeing private data Linmao Li
2026-07-20 3:48 ` sashiko-bot
2026-07-20 5:18 ` Dmitry Torokhov [this message]
2026-07-20 6:12 ` [PATCH v2] " Linmao Li
2026-07-20 6:26 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al2hgrtDg3uSgbVR@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=lilinmao@kylinos.cn \
--cc=linux-input@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox