* [PATCH] iommu/vt-d: fix wrong use of pasid config
@ 2024-04-01 6:07 Xuchun Shang
2024-04-09 12:58 ` Liang, Kan
0 siblings, 1 reply; 3+ messages in thread
From: Xuchun Shang @ 2024-04-01 6:07 UTC (permalink / raw)
To: Joerg Roedel, Will Deacon, Lu Baolu, Kan Liang, iommu; +Cc: Xuchun Shang
The commit "iommu/vt-d: Add IOMMU perfmon support" introduce IOMMU
PMU feature, but use the wrong config when set pasid filter.
Fixes: 7232ab8b89e9 ("iommu/vt-d: Add IOMMU perfmon support")
Signed-off-by: Xuchun Shang <xuchun.shang@linux.alibaba.com>
---
drivers/iommu/intel/perfmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel/perfmon.c b/drivers/iommu/intel/perfmon.c
index cf43e798eca4..44083d01852d 100644
--- a/drivers/iommu/intel/perfmon.c
+++ b/drivers/iommu/intel/perfmon.c
@@ -438,7 +438,7 @@ static int iommu_pmu_assign_event(struct iommu_pmu *iommu_pmu,
iommu_pmu_set_filter(domain, event->attr.config1,
IOMMU_PMU_FILTER_DOMAIN, idx,
event->attr.config1);
- iommu_pmu_set_filter(pasid, event->attr.config1,
+ iommu_pmu_set_filter(pasid, event->attr.config2,
IOMMU_PMU_FILTER_PASID, idx,
event->attr.config1);
iommu_pmu_set_filter(ats, event->attr.config2,
--
2.39.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iommu/vt-d: fix wrong use of pasid config
2024-04-01 6:07 [PATCH] iommu/vt-d: fix wrong use of pasid config Xuchun Shang
@ 2024-04-09 12:58 ` Liang, Kan
2024-04-11 2:50 ` Baolu Lu
0 siblings, 1 reply; 3+ messages in thread
From: Liang, Kan @ 2024-04-09 12:58 UTC (permalink / raw)
To: Xuchun Shang, Joerg Roedel, Will Deacon, Lu Baolu, iommu
On 2024-04-01 2:07 a.m., Xuchun Shang wrote:
> The commit "iommu/vt-d: Add IOMMU perfmon support" introduce IOMMU
> PMU feature, but use the wrong config when set pasid filter.
>
> Fixes: 7232ab8b89e9 ("iommu/vt-d: Add IOMMU perfmon support")
> Signed-off-by: Xuchun Shang <xuchun.shang@linux.alibaba.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
> ---
> drivers/iommu/intel/perfmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel/perfmon.c b/drivers/iommu/intel/perfmon.c
> index cf43e798eca4..44083d01852d 100644
> --- a/drivers/iommu/intel/perfmon.c
> +++ b/drivers/iommu/intel/perfmon.c
> @@ -438,7 +438,7 @@ static int iommu_pmu_assign_event(struct iommu_pmu *iommu_pmu,
> iommu_pmu_set_filter(domain, event->attr.config1,
> IOMMU_PMU_FILTER_DOMAIN, idx,
> event->attr.config1);
> - iommu_pmu_set_filter(pasid, event->attr.config1,
> + iommu_pmu_set_filter(pasid, event->attr.config2,
> IOMMU_PMU_FILTER_PASID, idx,
> event->attr.config1);
> iommu_pmu_set_filter(ats, event->attr.config2,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iommu/vt-d: fix wrong use of pasid config
2024-04-09 12:58 ` Liang, Kan
@ 2024-04-11 2:50 ` Baolu Lu
0 siblings, 0 replies; 3+ messages in thread
From: Baolu Lu @ 2024-04-11 2:50 UTC (permalink / raw)
To: Liang, Kan, Xuchun Shang, Joerg Roedel, Will Deacon, iommu; +Cc: baolu.lu
On 4/9/24 8:58 PM, Liang, Kan wrote:
>
> On 2024-04-01 2:07 a.m., Xuchun Shang wrote:
>> The commit "iommu/vt-d: Add IOMMU perfmon support" introduce IOMMU
>> PMU feature, but use the wrong config when set pasid filter.
>>
>> Fixes: 7232ab8b89e9 ("iommu/vt-d: Add IOMMU perfmon support")
>> Signed-off-by: Xuchun Shang<xuchun.shang@linux.alibaba.com>
> Reviewed-by: Kan Liang<kan.liang@linux.intel.com>
Queued for v6.9-rc. Thanks Xuchun and Kan.
Best regards,
baolu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-11 2:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-01 6:07 [PATCH] iommu/vt-d: fix wrong use of pasid config Xuchun Shang
2024-04-09 12:58 ` Liang, Kan
2024-04-11 2:50 ` Baolu Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox