[PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()

[PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()

[Minjie Du]

debugfs_create_file() will simply return early if
 smmu->debugfs is an error pointer.
Make smmu->debugfs check delete in tegra_smmu_debugfs_init().

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/iommu/tegra-smmu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 1cbf063cc..2137040b7 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -1056,8 +1056,6 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients);
 static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
 {
 	smmu->debugfs = debugfs_create_dir("smmu", NULL);
-	if (!smmu->debugfs)
-		return;
 
 	debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu,
 			    &tegra_smmu_swgroups_fops);
-- 
2.39.0

Re: [PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Thu, Jul 13, 2023 at 10:56:53AM +0800, Minjie Du wrote:
> debugfs_create_file() will simply return early if
>  smmu->debugfs is an error pointer.

The formatting is a little weird here.

> Make smmu->debugfs check delete in tegra_smmu_debugfs_init().

I think something like this is better:

  Delete smmu->debugfs check in ...

Or perhaps combine both sentences:

  debugfs_create_file() will return early if smmu->debugfs is an error
  pointer, so an extra error check is not needed.

With that fixed:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()

[Markus Elfring]

>   debugfs_create_file() will return early if smmu->debugfs is an error
>   pointer, so an extra error check is not needed.
>
> With that fixed:
>
> Acked-by: Thierry Reding <treding@nvidia.com>

Are there any risks to consider with your presentation of this tag “in advance”?


I would also appreciate another improved imperative change description.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94


Would a subject like “[PATCH v3] iommu: Remove redundant error check in tegra_smmu_debugfs_init()”
be more appropriate?

Regards,
Markus