Re: [PATCH v5 08/14] iommu/amd: Consolidate feature detection and reporting logic

[Jason Gunthorpe <jgg@ziepe.ca>]

On Mon, Aug 21, 2023 at 10:42:21AM +0000, Vasant Hegde wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 
> Currently, IOMMU driver assumes capabilities on all IOMMU instances to be
> homogeneous. During early_amd_iommu_init(), the driver probes all IVHD
> blocks and do sanity check to make sure that only features common among all
> IOMMU instances are supported. This is tracked in the global amd_iommu_efr
> and amd_iommu_efr2, which should be used whenever the driver need to check
> hardware capabilities.
> 
> Therefore, introduce check_feature() and check_feature2(), and modify
> the driver to adopt the new helper functions.
> 
> In addition, clean up the print_iommu_info() to avoid reporting redundant
> EFR/EFR2 for each IOMMU instance.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
>  drivers/iommu/amd/amd_iommu.h       | 17 ++++--
>  drivers/iommu/amd/amd_iommu_types.h |  4 ++
>  drivers/iommu/amd/init.c            | 89 ++++++++++++-----------------
>  drivers/iommu/amd/iommu.c           |  4 +-
>  4 files changed, 54 insertions(+), 60 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason